Summary: | Web Inspector: add memory instrumentation for CSSValue and its descendants | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | alph, apavlov, bweinstein, cmarcelo, eric.carlson, feature-media-reviews, gustavo, joepeck, keishi, koivisto, loislo, macpherson, menard, pfeldman, philn, pmuellr, rik, timothy, webkit.review.bot, xan.lopez, yurys | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | 92748 | ||||||||||||||
Bug Blocks: | 87262 | ||||||||||||||
Attachments: |
|
Description
Yury Semikhatsky
2012-08-03 09:21:18 PDT
Created attachment 156398 [details]
Patch
Comment on attachment 156398 [details] Patch Attachment 156398 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13434081 Comment on attachment 156398 [details] Patch Attachment 156398 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13423861 Comment on attachment 156398 [details] Patch Attachment 156398 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13426670 Comment on attachment 156398 [details] Patch Attachment 156398 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13428711 Created attachment 156629 [details]
Patch
Created attachment 156631 [details]
Patch
Comment on attachment 156631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156631&action=review > Source/WebCore/css/CSSCrossfadeValue.cpp:147 > + MemoryClassInfo<CSSCrossfadeValue> info(memoryObjectInfo, this, MemoryInstrumentation::CSS); > + info.addInstrumentedMember(m_fromValue); > + info.addInstrumentedMember(m_toValue); > + info.addInstrumentedMember(m_percentageValue); > + // FIXME: add instrumentation for > + // m_cachedFromImage > + // m_cachedToImage > + // m_generatedImage looks like you missed to call CSSImageGeneratorValue::reportDescendantMemoryUsage Comment on attachment 156631 [details] Patch Attachment 156631 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13438638 Created attachment 156643 [details]
Patch
(In reply to comment #8) > (From update of attachment 156631 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156631&action=review > > > Source/WebCore/css/CSSCrossfadeValue.cpp:147 > > + MemoryClassInfo<CSSCrossfadeValue> info(memoryObjectInfo, this, MemoryInstrumentation::CSS); > > + info.addInstrumentedMember(m_fromValue); > > + info.addInstrumentedMember(m_toValue); > > + info.addInstrumentedMember(m_percentageValue); > > + // FIXME: add instrumentation for > > + // m_cachedFromImage > > + // m_cachedToImage > > + // m_generatedImage > > looks like you missed to call CSSImageGeneratorValue::reportDescendantMemoryUsage Added CSSImageGeneratorValue::reportBaseClassMemoryUsage call Comment on attachment 156643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156643&action=review > Source/WebCore/css/CSSCursorImageValue.cpp:139 > + MemoryClassInfo<CSSCursorImageValue> info(memoryObjectInfo, this, MemoryInstrumentation::CSS); > +#if ENABLE(SVG) CSSImageValue::reportBaseClassMemoryUsage ? (In reply to comment #11) > (In reply to comment #8) > > (From update of attachment 156631 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=156631&action=review > > > > > Source/WebCore/css/CSSCrossfadeValue.cpp:147 > > > + MemoryClassInfo<CSSCrossfadeValue> info(memoryObjectInfo, this, MemoryInstrumentation::CSS); > > > + info.addInstrumentedMember(m_fromValue); > > > + info.addInstrumentedMember(m_toValue); > > > + info.addInstrumentedMember(m_percentageValue); > > > + // FIXME: add instrumentation for > > > + // m_cachedFromImage > > > + // m_cachedToImage > > > + // m_generatedImage > > > > looks like you missed to call CSSImageGeneratorValue::reportDescendantMemoryUsage > > Added CSSImageGeneratorValue::reportBaseClassMemoryUsage call Done. Created attachment 156661 [details]
Patch
lgtm Committed r124768: <http://trac.webkit.org/changeset/124768> |