Summary: | [V8] Remove V8Proxy::registerExtensionWithV8() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 85330 | ||||||||
Attachments: |
|
Description
Kentaro Hara
2012-08-03 07:13:30 PDT
Created attachment 156369 [details]
Patch
Comment on attachment 156369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156369&action=review > Source/WebCore/bindings/v8/V8Proxy.cpp:678 > +const V8Extensions& V8Proxy::extensions() Why have both staticExtensionsList() and V8Proxy::extensions() ? (In reply to comment #2) > (From update of attachment 156369 [details]) > > Source/WebCore/bindings/v8/V8Proxy.cpp:678 > > +const V8Extensions& V8Proxy::extensions() > > Why have both staticExtensionsList() and V8Proxy::extensions() ? - staticExtensionsList() is not const and can be used by V8Proxy.cpp only. - extensions() is const and can be used by outside (i.e. V8DOMWindowShell.cpp) Shall we merge them by removing const? > Shall we merge them by removing const?
I'm not sure it's a big deal either way. I leave it up to your judgement.
(In reply to comment #4) > > Shall we merge them by removing const? > > I'm not sure it's a big deal either way. I leave it up to your judgement. OK, let me merge them and land it (after depending patches are landed). Created attachment 156558 [details]
patch for landing
Comment on attachment 156558 [details] patch for landing Clearing flags on attachment: 156558 Committed r124716: <http://trac.webkit.org/changeset/124716> |