[CSSRegions]regionOverset is computed as "overset" even though the region is not the last in the chain

• Component: CSS
• Status: RESOLVED FIXED

[Andrei Onea]

The latest CSSRegions spec says that Element.regionOverflow should only return "'overflow" for the last region in the region chain, if the content cannot fit inside it. http://dev.w3.org/csswg/css3-regions/#dom-region-regionoverset . The current implementation uses the older spec, which allows regions that are not the last in the region chain to have the regionOverflow property set to "overflow".

[Andrei Onea]

Created attachment 156344 [details]
Patch

[Andrei Onea]

Created attachment 157219 [details]
Patch

Modified patch to use regionOverset property and overset property value

[Allan Sandfeld Jensen]

Comment on attachment 157219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157219&action=review

> LayoutTests/ChangeLog:14
> +        * fast/regions/element-region-overflow-state-expected.txt:
> +        * fast/regions/element-region-overflow-state-vertical-rl-expected.txt:
> +        * fast/regions/element-region-overflow-state-vertical-rl.html:
> +        * fast/regions/element-region-overflow-state.html:

I think you need to update the changelog it doesn't match the files changed below.

[Andrei Onea]

Created attachment 157239 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 157239 [details]
Patch

OK.

[WebKit Review Bot]

Comment on attachment 157239 [details]
Patch

Clearing flags on attachment: 157239

Committed r125600: <http://trac.webkit.org/changeset/125600>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.