Bug 93101 – [V8] Add an IsExecutionTerminating() check to setDOMException()

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Kentaro Hara]

In preparation for moving exception related code from V8Proxy to V8Binding, I am going to remove throwError(ExceptionCode, v8::Isolate*) from V8Proxy. throwError(ExceptionCode, v8::Isolate*) will be replaced with setDOMException(ExceptionCode, v8::Isolate*). By this refactoring, the way to throw JavaScript errors and DOM exceptions becomes simple: "Throw JavaScript errors by throwError(). Throw DOM exceptions by setDOMException()". (Currently, some DOM exceptions are thrown by throwError().)

To keep the current behavior of throwError(ExceptionCode, v8::Isolate*), before the replacement, we need to insert the IsExecutionTerminating() check to setDOMException(). This will add an extra check to the current setDOMException(), but I don't think it's a problem.

[Kentaro Hara]

Created attachment 156339 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156339 [details]
Patch

Attachment 156339 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13426596

New failing tests:
canvas/philip/tests/2d.drawImage.zerosource.html
canvas/philip/tests/2d.pattern.basic.zerocanvas.html
canvas/philip/tests/2d.missingargs.html
canvas/philip/tests/2d.imageData.get.nonfinite.html
http/tests/appcache/online-whitelist.html
canvas/philip/tests/2d.imageData.put.nonfinite.html
http/tests/appcache/manifest-parsing.html
http/tests/appcache/reload.html
canvas/philip/tests/2d.gradient.radial.negative.html
canvas/philip/tests/2d.gradient.object.invalidcolour.html
canvas/philip/tests/2d.gradient.linear.nonfinite.html
canvas/philip/tests/2d.imageData.create1.zero.html
http/tests/appcache/access-via-redirect.php
canvas/philip/tests/2d.drawImage.zerocanvas.html
canvas/philip/tests/2d.imageData.create2.zero.html
http/tests/appcache/disabled.html
canvas/philip/tests/2d.imageData.get.zero.html
http/tests/appcache/simple.html
canvas/philip/tests/2d.imageData.put.null.html
canvas/philip/tests/2d.path.arc.negative.html
canvas/philip/tests/2d.imageData.create2.nonfinite.html
canvas/philip/tests/2d.path.arcTo.negative.html
canvas/philip/tests/2d.gradient.object.invalidoffset.html
canvas/philip/tests/2d.gradient.radial.nonfinite.html
canvas/philip/tests/2d.drawImage.null.html
http/tests/appcache/remove-cache.html
canvas/philip/tests/2d.pattern.image.null.html
http/tests/appcache/xhr-foreign-resource.html

[WebKit Review Bot]

Created attachment 156345 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Kentaro Hara]

(In reply to comment #0)
> This will add an extra check to the current setDOMException(), but I don't think it's a problem.

Looks like it's a problem:)

[Kentaro Hara]

Created attachment 156352 [details]
Patch

[Kentaro Hara]

(In reply to comment #4)
> (In reply to comment #0)
> > This will add an extra check to the current setDOMException(), but I don't think it's a problem.
> 
> Looks like it's a problem:)

Sorry, the failures are just due to my typo.

[WebKit Review Bot]

Comment on attachment 156352 [details]
Patch

Clearing flags on attachment: 156352

Committed r124634: <http://trac.webkit.org/changeset/124634>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.