Summary: | [V8] Add an IsExecutionTerminating() check to setDOMException() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, japhet, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 85330 | ||||||||||
Attachments: |
|
Description
Kentaro Hara
2012-08-03 05:52:19 PDT
Created attachment 156339 [details]
Patch
Comment on attachment 156339 [details] Patch Attachment 156339 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13426596 New failing tests: canvas/philip/tests/2d.drawImage.zerosource.html canvas/philip/tests/2d.pattern.basic.zerocanvas.html canvas/philip/tests/2d.missingargs.html canvas/philip/tests/2d.imageData.get.nonfinite.html http/tests/appcache/online-whitelist.html canvas/philip/tests/2d.imageData.put.nonfinite.html http/tests/appcache/manifest-parsing.html http/tests/appcache/reload.html canvas/philip/tests/2d.gradient.radial.negative.html canvas/philip/tests/2d.gradient.object.invalidcolour.html canvas/philip/tests/2d.gradient.linear.nonfinite.html canvas/philip/tests/2d.imageData.create1.zero.html http/tests/appcache/access-via-redirect.php canvas/philip/tests/2d.drawImage.zerocanvas.html canvas/philip/tests/2d.imageData.create2.zero.html http/tests/appcache/disabled.html canvas/philip/tests/2d.imageData.get.zero.html http/tests/appcache/simple.html canvas/philip/tests/2d.imageData.put.null.html canvas/philip/tests/2d.path.arc.negative.html canvas/philip/tests/2d.imageData.create2.nonfinite.html canvas/philip/tests/2d.path.arcTo.negative.html canvas/philip/tests/2d.gradient.object.invalidoffset.html canvas/philip/tests/2d.gradient.radial.nonfinite.html canvas/philip/tests/2d.drawImage.null.html http/tests/appcache/remove-cache.html canvas/philip/tests/2d.pattern.image.null.html http/tests/appcache/xhr-foreign-resource.html Created attachment 156345 [details]
Archive of layout-test-results from gce-cr-linux-07
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
(In reply to comment #0) > This will add an extra check to the current setDOMException(), but I don't think it's a problem. Looks like it's a problem:) Created attachment 156352 [details]
Patch
(In reply to comment #4) > (In reply to comment #0) > > This will add an extra check to the current setDOMException(), but I don't think it's a problem. > > Looks like it's a problem:) Sorry, the failures are just due to my typo. Comment on attachment 156352 [details] Patch Clearing flags on attachment: 156352 Committed r124634: <http://trac.webkit.org/changeset/124634> All reviewed patches have been landed. Closing bug. |