Bug 93061

Summary: [GTK] Build break when building DumpRenderTree/gtk/EditingCallbacks.cpp
Product: WebKit Reporter: Joone Hur <joone>
Component: WebKitGTKAssignee: Joone Hur <joone>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, arv, gustavo, mrobinson, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joone Hur
Reported 2012-08-02 18:58:09 PDT
CXX Tools/DumpRenderTree/gtk/Programs_DumpRenderTree-EditingCallbacks.o CXXLD Programs/TestWebKitAPI/TestWTF ../../Tools/DumpRenderTree/gtk/EditingCallbacks.cpp: In function ‘gboolean shouldShowDeleteInterfaceForElement(WebKitWebView*, WebKitDOMHTMLElement*)’: ../../Tools/DumpRenderTree/gtk/EditingCallbacks.cpp:141:83: error: ‘webkit_dom_html_element_get_class_name’ was not declared in this scope make[1]: *** [Tools/DumpRenderTree/gtk/Programs_DumpRenderTree-EditingCallbacks.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug' make: *** [all] Error 2
Attachments
Patch (1.53 KB, patch)
2012-08-02 20:15 PDT, Joone Hur 		no flags
DetailsFormatted DiffDiff
Patch (1.53 KB, patch)
2012-08-02 20:34 PDT, Joone Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2012-08-02 20:15:17 PDT
Created attachment 156251 [details] Patch
Joone Hur
Comment 2 2012-08-02 20:22:27 PDT
Comment on attachment 156251 [details] Patch I'm not sure if this is a right way to fix this problem, but checked there is no regression error while running LayoutTests/editing. Feel free to revert this commit if there is any problem.
Joone Hur
Comment 3 2012-08-02 20:28:40 PDT
Comment on attachment 156251 [details] Patch Need to fix typo
Joone Hur
Comment 4 2012-08-02 20:34:57 PDT
Created attachment 156252 [details] Patch
Joone Hur
Comment 5 2012-08-02 21:10:25 PDT
className has been defined on Element and not on HTMLElement since http://trac.webkit.org/changeset/124499 applied.
WebKit Review Bot
Comment 6 2012-08-02 21:42:30 PDT
Comment on attachment 156252 [details] Patch Clearing flags on attachment: 156252 Committed r124559: <http://trac.webkit.org/changeset/124559>
WebKit Review Bot
Comment 7 2012-08-02 21:42:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.