Bug 9304

Summary:

Minor cleanup in JavaScriptCore

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

JavaScriptCore

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gavin.sharp

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch	mjs: review-

Geoffrey Garen

Reported 2006-06-04 11:34:37 PDT

Patch coming.

Attachments
Patch (1.58 KB, patch) 2006-06-04 11:36 PDT, Geoffrey Garen	mjs: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2006-06-04 11:36:41 PDT

Created attachment 8695 [details] Patch

Maciej Stachowiak

Comment 2 2006-06-04 16:02:41 PDT

Comment on attachment 8695 [details] Patch Removing the declarations is right, but I don't think the change to 3 to 4 is necessary. Characters that require 4 bytes in UTF-8 also require a surrogate pair in UTF-16, which is treated as two characters.

Maciej Stachowiak

Comment 3 2006-06-04 16:07:15 PDT

Comment on attachment 8695 [details] Patch r- (but fine with me if it turns out I am wrong about the UTF8 thing)

Geoffrey Garen

Comment 4 2006-06-04 20:01:40 PDT

Thanks for the info about UTF-8; I hadn't considered that. I'm going to land just the header change.

Geoffrey Garen

Comment 5 2006-06-04 20:04:33 PDT

Committed revision 14731.

Note You need to log in before you can comment on or make changes to this bug.