Bug 92992

Summary: Limited the number of queried cached build infos in URLs used by Garden-o-matic.
Product: WebKit Reporter: Ádám Kallai <kadam>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, galpeter, kadam, kkristof, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
draft patch
none
proposed patch none

Ádám Kallai
Reported 2012-08-02 07:46:13 PDT
Limited the number of queried cached builds. I tried to add a reasonable limit. I need it, because I would like to add the QTSED bots to garden-o-matic. These bots store about 100 cached builds. When the Garden-o-matic gets the cached build information then it hangs up, because the URL is too long. Do you prefer setting this limit number in config.js globally or should it be set per platform? I'm going to upload the draft patch.
Attachments
draft patch (1.05 KB, patch)
2012-08-02 07:47 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
proposed patch (2.51 KB, patch)
2012-08-03 06:47 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ádám Kallai
Comment 1 2012-08-02 07:47:32 PDT
Created attachment 156082 [details] draft patch
Adam Barth
Comment 2 2012-08-02 08:24:51 PDT
> Do you prefer setting this limit number in config.js globally or should it be set per platform? I'd start with a global constant in config.js. We can change it to be per-platform if folks want to customize it for different platforms. (Also, your patch will need a ChangeLog, which can be generated by prepare-ChangeLogs.)
Ádám Kallai
Comment 3 2012-08-03 06:47:14 PDT
Created attachment 156355 [details] proposed patch Thanks for your comment. I fixed my patch.
Adam Barth
Comment 4 2012-08-03 09:52:24 PDT
Comment on attachment 156355 [details] proposed patch Ok.
WebKit Review Bot
Comment 5 2012-08-03 12:00:29 PDT
Comment on attachment 156355 [details] proposed patch Clearing flags on attachment: 156355 Committed r124635: <http://trac.webkit.org/changeset/124635>
WebKit Review Bot
Comment 6 2012-08-03 12:00:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.