Bug 92982

Summary:

Add ASCII flag to StringImpl

Product:

WebKit

Reporter:

Dan Carney <dcarney>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

darin, eric, gustavo, jochen, msaboff, philn, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

92677

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
sunspider and v8 performance comparison	none
Patch	none
Performance tests results for 158263	none

Dan Carney

Reported 2012-08-02 06:18:57 PDT

Add ASCII flag to StringImpl

Attachments
Patch (27.47 KB, patch) 2012-08-02 06:28 PDT, Dan Carney	no flags	Details Formatted Diff Diff
Patch (27.49 KB, patch) 2012-08-02 07:23 PDT, Dan Carney	no flags	Details Formatted Diff Diff
Patch (29.55 KB, patch) 2012-08-07 08:52 PDT, Dan Carney	no flags	Details Formatted Diff Diff
sunspider and v8 performance comparison (3.61 KB, text/plain) 2012-08-08 04:29 PDT, Dan Carney	no flags	Details
Patch (30.47 KB, patch) 2012-08-14 02:10 PDT, Dan Carney	no flags	Details Formatted Diff Diff
Performance tests results for 158263 (92.19 KB, text/html) 2012-08-14 13:47 PDT, Perf EWS	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dan Carney

Comment 1 2012-08-02 06:28:19 PDT

Created attachment 156066 [details] Patch

Build Bot

Comment 2 2012-08-02 06:54:32 PDT

Comment on attachment 156066 [details] Patch Attachment 156066 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13422412

Build Bot

Comment 3 2012-08-02 06:54:49 PDT

Comment on attachment 156066 [details] Patch Attachment 156066 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13411883

Early Warning System Bot

Comment 4 2012-08-02 07:15:52 PDT

Comment on attachment 156066 [details] Patch Attachment 156066 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13415614

Dan Carney

Comment 5 2012-08-02 07:23:45 PDT

Created attachment 156078 [details] Patch

Build Bot

Comment 6 2012-08-02 07:54:14 PDT

Comment on attachment 156078 [details] Patch Attachment 156078 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13404827

Early Warning System Bot

Comment 7 2012-08-02 07:58:12 PDT

Comment on attachment 156078 [details] Patch Attachment 156078 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13419485

Build Bot

Comment 8 2012-08-02 08:07:36 PDT

Comment on attachment 156078 [details] Patch Attachment 156078 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13411903

jochen

Comment 9 2012-08-02 08:24:39 PDT

Comment on attachment 156078 [details] Patch marking r- for now as it doesn't compile

Alexey Proskuryakov

Comment 10 2012-08-02 14:33:09 PDT

How did you measure performance impact (particularly on JSC)?

Dan Carney

Comment 11 2012-08-07 08:52:20 PDT

Created attachment 156953 [details] Patch

Dan Carney

Comment 12 2012-08-07 08:55:10 PDT

(In reply to comment #10) > How did you measure performance impact (particularly on JSC)? I ran the performance tests for the chromium build. There was no change. Once I have a stable mac build, I'll rerun the tests and post the results. Is there anything you had in mind that I should post in particular, or do the Dromaeo tests cover your concerns?

Michael Saboff

Comment 13 2012-08-07 09:03:21 PDT

(In reply to comment #12) > (In reply to comment #10) > > How did you measure performance impact (particularly on JSC)? > > I ran the performance tests for the chromium build. There was no change. Once I have a stable mac build, I'll rerun the tests and post the results. Is there anything you had in mind that I should post in particular, or do the Dromaeo tests cover your concerns? Also run sunspider and V8.

Dan Carney

Comment 14 2012-08-08 04:29:41 PDT

Created attachment 157179 [details] sunspider and v8 performance comparison

Dan Carney

Comment 15 2012-08-14 02:10:07 PDT

Created attachment 158263 [details] Patch

jochen

Comment 16 2012-08-14 04:25:18 PDT

Comment on attachment 158263 [details] Patch temporarily setting cq+ for perfalizer bot to pick up the patch

jochen

Comment 17 2012-08-14 04:34:05 PDT

Comment on attachment 158263 [details] Patch clearing cq again

jochen

Comment 18 2012-08-14 08:25:31 PDT

Comment on attachment 158263 [details] Patch next try for the perfalizer bot

Perf EWS

Comment 19 2012-08-14 13:47:57 PDT

Created attachment 158407 [details] Performance tests results for 158263

Dan Carney

Comment 20 2012-08-17 03:06:07 PDT

(In reply to comment #10) > How did you measure performance impact (particularly on JSC)? Okay all the performance numbers are in. The v8 and sunspider tests show no change, and the full performance suite shows more or less inconclusive results, which are to be expected as the change is small. Is there anything else you'd like to see?

Note You need to log in before you can comment on or make changes to this bug.