Bug 92945

Summary:

ColorSuggestionPicker popup's height doesn't get smaller than 100 px

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed UI	none
Vertically centered	none
Patch	none
Patch	none
Archive of layout-test-results from gce-cr-linux-07	none
Patch	none

Keishi Hattori

Reported 2012-08-01 22:45:19 PDT

According to DOMWindow::adjustWindowRect, a window has a min width/height of 100px.

Attachments
Proposed UI (58.21 KB, image/png) 2012-08-02 05:25 PDT, Keishi Hattori	no flags	Details
Vertically centered (49.11 KB, image/png) 2012-08-02 05:54 PDT, Keishi Hattori	no flags	Details
Patch (1.58 KB, patch) 2012-08-02 06:02 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (14.53 KB, patch) 2012-08-02 06:34 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-07 (1.73 MB, application/zip) 2012-08-02 07:59 PDT, WebKit Review Bot	no flags	Details
Patch (15.40 KB, patch) 2012-08-02 18:36 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Keishi Hattori

Comment 1 2012-08-02 05:25:20 PDT

Created attachment 156046 [details] Proposed UI How about this? We need three rows to be larger than 100px. I made the color swatches fill the space for the first row because having two empty rows is strange.

Keishi Hattori

Comment 2 2012-08-02 05:54:32 PDT

Created attachment 156056 [details] Vertically centered Vertically centered.

Keishi Hattori

Comment 3 2012-08-02 06:02:20 PDT

Created attachment 156057 [details] Patch

Kent Tamura

Comment 4 2012-08-02 06:10:23 PDT

Comment on attachment 156057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156057&action=review > Source/WebCore/ChangeLog:12 > + No new tests. Covered in color-suggestion-popup-appearance.html It doesn't cover cases with one or two rows, right?

Keishi Hattori

Comment 5 2012-08-02 06:34:11 PDT

Created attachment 156068 [details] Patch

Kent Tamura

Comment 6 2012-08-02 07:18:05 PDT

Comment on attachment 156068 [details] Patch ok

WebKit Review Bot

Comment 7 2012-08-02 07:59:00 PDT

Comment on attachment 156068 [details] Patch Attachment 156068 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13430010 New failing tests: platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html

WebKit Review Bot

Comment 8 2012-08-02 07:59:03 PDT

Created attachment 156084 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Keishi Hattori

Comment 9 2012-08-02 18:36:29 PDT

Created attachment 156233 [details] Patch

WebKit Review Bot

Comment 10 2012-08-03 03:49:52 PDT

Comment on attachment 156233 [details] Patch Clearing flags on attachment: 156233 Committed r124593: <http://trac.webkit.org/changeset/124593>

WebKit Review Bot

Comment 11 2012-08-03 03:49:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.