Summary: | BUG in QTWebkit 4.8 > Flash | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Janton <janton.koster> | ||||||||||
Component: | WebKit Qt | Assignee: | Simon Hausmann <hausmann> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Major | CC: | abecsi, allan.jensen, c0d3r85, dczechowicz, hausmann, jturcotte, patrick, sfcheng, webkit.review.bot, wingzx3 | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Windows Vista | ||||||||||||
URL: | http://www.qtcentre.org/threads/50286-BUG-in-QTWebkit-4-8-gt-Flash | ||||||||||||
Attachments: |
|
Description
Janton
2012-08-01 13:38:33 PDT
Created attachment 155875 [details] scrolling up and down on this page: http://www.wechoosethemoon.org/ Created attachment 155876 [details]
youtube page when there is a banner
i don't know what verion QTWebkit has in the last 4.8.2 release? I also reported the issue here: http://www.qtcentre.org/threads/50286-BUG-in-QTWebkit-4-8-gt-Flash but no responds yet! Am I the only one? Have the same behaviour in QtWebKit v4.9.2. There is no such bug in QtWebKit v 4.7.4. It's being painted to the wrong Rect. The following patch fixes it: Index: win/PluginViewWin.cpp =================================================================== --- Source/WebCore/plugins/win/PluginViewWin.cpp (revision 63895) +++ Source/WebCore/plugins/win/PluginViewWin.cpp (working copy) @@ -618,7 +618,8 @@ ASSERT(parent()->isFrameView()); IntRect rectInWindow = static_cast<FrameView*>(parent())->contentsToWindow( frameRect()); - LocalWindowsContext windowsContext(context, rectInWindow, m_isTransparent); + HDC hdc = context->getWindowsContext(rectInWindow, m_isTransparent); + // On Safari/Windows without transparency layers the GraphicsContext return s the HDC // of the window and the plugin expects that the passed in DC has window co ordinates. @@ -627,14 +628,15 @@ #if !PLATFORM(QT) && !OS(WINCE) if (!context->inTransparencyLayer()) { XFORM transform; - GetWorldTransform(windowsContext.hdc(), &transform); + GetWorldTransform(hdc, &transform); transform.eDx = 0; transform.eDy = 0; - SetWorldTransform(windowsContext.hdc(), &transform); + SetWorldTransform(hdc, &transform); } #endif - paintIntoTransformedContext(windowsContext.hdc()); + paintIntoTransformedContext(hdc); + context->releaseWindowsContext(hdc, frameRect(), m_isTransparent); } Created attachment 163742 [details]
Paint the flash video in the actual rect
Great thank you very much you build webkit 2.2.2 or which version? alone or with qt? (In reply to comment #8) > Great thank you very much i confirm work well on xp and win 7 use qt webkit 2.2.2 from here https://gitorious.org/webkit/qtwebkit/trees/qtwebkit-2.2.2 Comment on attachment 163742 [details] Paint the flash video in the actual rect This seemed to have been broken in http://trac.webkit.org/changeset/67125 I wonder if there would be a way to keep using LocalWindowsContext, maybe by adjusting the coordinates like GTK did in http://trac.webkit.org/changeset/121441. (In reply to comment #10) > (From update of attachment 163742 [details]) > This seemed to have been broken in http://trac.webkit.org/changeset/67125 > I wonder if there would be a way to keep using LocalWindowsContext, maybe by adjusting the coordinates like GTK did in http://trac.webkit.org/changeset/121441. Well spotted!! I think is a duplicate of bug #71950 *** Bug 71950 has been marked as a duplicate of this bug. *** Created attachment 164568 [details]
Patch
Patch that enables the same code path as Gtk. Tested on Windows with youtube and QtTestBrowser.exe
Comment on attachment 164568 [details] Patch Clearing flags on attachment: 164568 Committed r128978: <http://trac.webkit.org/changeset/128978> All reviewed patches have been landed. Closing bug. *** Bug 101242 has been marked as a duplicate of this bug. *** |