Bug 92884

Summary:

[EFL] Move some inspector tests into TestExpectations

Product:

WebKit

Reporter:

Seokju Kwon <seokju.kwon>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Seokju Kwon

Reported 2012-08-01 10:35:08 PDT

Move the following tests into TestExpectations. http/tests/inspector/filesystem/request-directory-content.html http/tests/inspector/filesystem/request-file-content.html http/tests/inspector/filesystem/request-filesystem-root.html http/tests/inspector/filesystem/directory-tree.html http/tests/inspector/filesystem/request-metadata.html inspector/profiler/heap-snapshot-inspect-dom-wrapper.html inspector/profiler/heap-snapshot-comparison-dom-groups-change.html inspector/profiler/heap-snapshot-comparison-show-all.html inspector/profiler/heap-snapshot-loader.html inspector/profiler/heap-snapshot-reveal-in-dominators-view.html inspector/profiler/heap-snapshot-summary-retainers.html inspector/profiler/heap-snapshot-summary-show-ranges.html inspector/profiler/heap-snapshot-summary-sorting-fields.html inspector/profiler/heap-snapshot-summary-sorting.html inspector/profiler/heap-snapshot-summary-sorting-instances.html

Attachments
Patch (4.29 KB, patch) 2012-08-01 10:46 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Patch (4.41 KB, patch) 2012-08-02 03:51 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Patch (4.33 KB, patch) 2012-08-02 06:18 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Patch (4.49 KB, patch) 2012-08-06 22:42 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Seokju Kwon

Comment 1 2012-08-01 10:46:03 PDT

Created attachment 155840 [details] Patch

Ryuan Choi

Comment 2 2012-08-02 03:33:04 PDT

Comment on attachment 155840 [details] Patch Please rebase patch for style bot to be green.

Seokju Kwon

Comment 3 2012-08-02 03:51:29 PDT

Created attachment 156031 [details] Patch

WebKit Review Bot

Comment 4 2012-08-02 05:03:34 PDT

Comment on attachment 156031 [details] Patch Rejecting attachment 156031 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: arty/v8-i18n --revision 105 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 113. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' Died at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2582. Full output: http://queues.webkit.org/results/13425181

Seokju Kwon

Comment 5 2012-08-02 06:18:22 PDT

Created attachment 156063 [details] Patch

WebKit Review Bot

Comment 6 2012-08-03 10:47:00 PDT

Comment on attachment 156063 [details] Patch Rejecting attachment 156063 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/efl/Skipped patching file LayoutTests/platform/efl/TestExpectations Hunk #1 succeeded at 633 (offset -11 lines). Hunk #2 FAILED at 841. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/efl/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13419963

Seokju Kwon

Comment 7 2012-08-06 22:42:42 PDT

Created attachment 156869 [details] Patch

WebKit Review Bot

Comment 8 2012-08-07 00:49:11 PDT

Comment on attachment 156869 [details] Patch Clearing flags on attachment: 156869 Committed r124863: <http://trac.webkit.org/changeset/124863>

WebKit Review Bot

Comment 9 2012-08-07 00:49:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.