Bug 92856

Summary: [chromium] Improve garbage collector hint if page uses Canvas contexts
Product: WebKit Reporter: Ulan Degenbaev <ulan>
Component: New BugsAssignee: Ulan Degenbaev <ulan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 76225    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Address comments none

Ulan Degenbaev
Reported 2012-08-01 02:26:04 PDT
[chromium] Improve garbage collector hint if page uses Canvas contexts
Attachments
Patch (5.30 KB, patch)
2012-08-01 02:36 PDT, Ulan Degenbaev 		no flags
DetailsFormatted DiffDiff
Address comments (5.31 KB, patch)
2012-08-02 01:44 PDT, Ulan Degenbaev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ulan Degenbaev
Comment 1 2012-08-01 02:36:53 PDT
Created attachment 155766 [details] Patch
Adam Barth
Comment 2 2012-08-01 11:24:06 PDT
Comment on attachment 155766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155766&action=review > Source/WebCore/bindings/v8/V8Binding.h:229 > + void setGarbageCollectionHint() { m_garbageCollectionHint = true; } > + void clearGarbageCollectionHint() { m_garbageCollectionHint = false; } > + bool isGarbageCollectionHint() const { return m_garbageCollectionHint; } How about: void setShouldCollectGarbageSoon(bool flag) { m_shouldCollectGarbageSoon = flag; } bool shouldCollectGarbageSoon() const { return m_shouldCollectGarbageSoon; }
Kenneth Russell
Comment 3 2012-08-01 15:01:15 PDT
Comment on attachment 155766 [details] Patch LGTM too; abarth's naming changes sound reasonable.
Ulan Degenbaev
Comment 4 2012-08-02 01:44:34 PDT
Created attachment 156006 [details] Address comments
Ulan Degenbaev
Comment 5 2012-08-02 01:51:10 PDT
Thanks, renamed and rebased. Could you send to CQ after review? I forgot to set the CQ request flag.
WebKit Review Bot
Comment 6 2012-08-02 02:26:53 PDT
Comment on attachment 156006 [details] Address comments Clearing flags on attachment: 156006 Committed r124431: <http://trac.webkit.org/changeset/124431>
WebKit Review Bot
Comment 7 2012-08-02 02:26:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.