[chromium] Improve garbage collector hint if page uses Canvas contexts

• Component: New Bugs
• Status: RESOLVED FIXED

[Ulan Degenbaev]

[chromium] Improve garbage collector hint if page uses Canvas contexts

[Ulan Degenbaev]

Created attachment 155766 [details]
Patch

[Adam Barth]

Comment on attachment 155766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155766&action=review

> Source/WebCore/bindings/v8/V8Binding.h:229
> +        void setGarbageCollectionHint() { m_garbageCollectionHint = true; }
> +        void clearGarbageCollectionHint() { m_garbageCollectionHint = false; }
> +        bool isGarbageCollectionHint() const { return m_garbageCollectionHint; }

How about:

void setShouldCollectGarbageSoon(bool flag) { m_shouldCollectGarbageSoon = flag; }
bool shouldCollectGarbageSoon() const { return m_shouldCollectGarbageSoon; }

[Kenneth Russell]

Comment on attachment 155766 [details]
Patch

LGTM too; abarth's naming changes sound reasonable.

[Ulan Degenbaev]

Created attachment 156006 [details]
Address comments

[Ulan Degenbaev]

Thanks, renamed and rebased. Could you send to CQ after review? I forgot to set the CQ request flag.

[WebKit Review Bot]

Comment on attachment 156006 [details]
Address comments

Clearing flags on attachment: 156006

Committed r124431: <http://trac.webkit.org/changeset/124431>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.