Bug 92754

Summary: skia: switch to conical gradient to match css/svg spec for two-point gradients
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Mike Reed 2012-07-31 07:44:52 PDT 
skia: switch to conical gradient to match css/svg spec for two-point gradients
Comment 1 Mike Reed 2012-07-31 07:49:55 PDT 
Created attachment 155535 [details]
Patch
Comment 2 Stephen White 2012-07-31 07:53:41 PDT 
Comment on attachment 155535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155535&action=review

> LayoutTests/platform/chromium/TestExpectations:1258
> +#BUGWK83303 WIN : svg/as-background-image/svg-as-background-3.html = PASS IMAGE

Shouldn't this be //, rather than #?
Comment 3 Mike Reed 2012-07-31 07:58:14 PDT 
Created attachment 155538 [details]
Patch
Comment 4 Mike Reed 2012-07-31 07:58:36 PDT 
doh. # replaced with //
Comment 5 Stephen White 2012-07-31 07:59:12 PDT 
Comment on attachment 155538 [details]
Patch

Looks fine, bots willing.  r=me
Comment 6 WebKit Review Bot 2012-07-31 08:56:06 PDT 
Comment on attachment 155538 [details]
Patch

Clearing flags on attachment: 155538

Committed r124209: <http://trac.webkit.org/changeset/124209>
Comment 7 WebKit Review Bot 2012-07-31 08:56:09 PDT 
All reviewed patches have been landed.  Closing bug.