Bug 92736 – REGRESSION(124116): Number of skipped tests isn't printed anymore

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

New form:
----------
02:48:47.588 1369 Found 30509 tests; running 26142.
02:48:47.592 1369 Expect: 26101 passes   (26101 now,    0 wontfix)
02:48:47.592 1369 Expect:    38 failures (   38 now,    0 wontfix)
02:48:47.592 1369 Expect:     3 flaky    (    3 now,    0 wontfix)


Old form:
----------
16:39:31.706 2661 Found 30506 tests.
16:39:31.710 2661 Expect: 26099 passes   (26099 now, 0 wontfix)
16:39:31.710 2661 Expect:    38 failures (   38 now, 0 wontfix)
16:39:31.710 2661 Expect:     3 flaky    (    3 now, 0 wontfix)
16:39:31.710 2661 Expect:  4366 skipped  ( 4366 now, 0 wontfix)

Unfortunately the number of skipped tests isn't printed anymore,
but it is still very important for us. Could you guys put it back?
It is a simple multiplication. :) Thanks is advance.

[Dirk Pranke]

Hi Ossy,

I apologize for the inconvenience; I didn't realize this number was important to anyone.

This changed because the way we were doing things previously introduced a fair amount of unpleasantness in the code.

You can still compute the number of skipped tests from the first line ("Found 30509; running 26142"), since you can subtract the one from the other. Is that good enough?

Or would it be helpful to print the subtracted number ("Found 30509; running 26142, skipping 4366" or something)?

Or do you really need the original format back? (If this is the case, it's not a big deal and I'll figure out how to make it work). 

Can you tell me what you're using this number for? Do you have some script parsing it for something, or is this just being read by humans?

[Csaba Osztrogonác]

Not a big problem, we don't use script to parse it, so we don't need the original format. You know there are so many skipped tests on Qt port and 
we are working hard to try to decrease this number, so we check the actual
number of skipped tests day by day, tests by tests. That's why it is important
for us.

"Found 30509; running 26142, skipping 4366" is absolutely good for us. ;)

[Dirk Pranke]

Created attachment 155590 [details]
Patch

[WebKit Review Bot]

Comment on attachment 155590 [details]
Patch

Clearing flags on attachment: 155590

Committed r124234: <http://trac.webkit.org/changeset/124234>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.