Summary: | REGRESSION(124116): Number of skipped tests isn't printed anymore | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, cmarcelo, dpranke, kadam, kkristof, ojan, ossy, rniwa, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 92527 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-07-31 03:40:05 PDT
Hi Ossy, I apologize for the inconvenience; I didn't realize this number was important to anyone. This changed because the way we were doing things previously introduced a fair amount of unpleasantness in the code. You can still compute the number of skipped tests from the first line ("Found 30509; running 26142"), since you can subtract the one from the other. Is that good enough? Or would it be helpful to print the subtracted number ("Found 30509; running 26142, skipping 4366" or something)? Or do you really need the original format back? (If this is the case, it's not a big deal and I'll figure out how to make it work). Can you tell me what you're using this number for? Do you have some script parsing it for something, or is this just being read by humans? Not a big problem, we don't use script to parse it, so we don't need the original format. You know there are so many skipped tests on Qt port and we are working hard to try to decrease this number, so we check the actual number of skipped tests day by day, tests by tests. That's why it is important for us. "Found 30509; running 26142, skipping 4366" is absolutely good for us. ;) Created attachment 155590 [details]
Patch
Comment on attachment 155590 [details] Patch Clearing flags on attachment: 155590 Committed r124234: <http://trac.webkit.org/changeset/124234> All reviewed patches have been landed. Closing bug. |