Summary: | CSS quotes output quotes when depth is negative | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Elliott Sprehn <esprehn> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Elliott Sprehn <esprehn> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | eric, jchaffraix, webkit.review.bot | ||||||||||||
Priority: | P2 | Keywords: | HasReduction | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 92061 | ||||||||||||||
Attachments: |
|
Description
Elliott Sprehn
2012-07-30 16:35:55 PDT
Created attachment 157063 [details]
Patch
Fix quotes when they go negative and add more tests.
Comment on attachment 157063 [details]
Patch
LGTM.
Comment on attachment 157063 [details] Patch Rejecting attachment 157063 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: st/css-generated-content/close-quote-negative-depth-expected.html patching file LayoutTests/fast/css-generated-content/close-quote-negative-depth.html patching file LayoutTests/fast/css-generated-content/nested-quote-more-than-pairs-expected.html patching file LayoutTests/fast/css-generated-content/nested-quote-more-than-pairs.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13459080 (In reply to comment #3) > (From update of attachment 157063 [details]) > Rejecting attachment 157063 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > Eric do you know what happened here? This isn't a test failure, it's svn-apply failing? I don't understand what happened. Yes, it's a horrible error message from a failed apply. You'll want to rebase the patch and re-upload (or have someone do so for you). I can help tomorrow if you like. This conflicts with WKBug 93056 so one or the other needs to land first. Created attachment 157607 [details]
Patch for landing
Comment on attachment 157607 [details] Patch for landing Rejecting attachment 157607 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 150169 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 150169. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13477056 Comment on attachment 157607 [details]
Patch for landing
This appears to be missing a ChangeLog. I suspect that's what the queue was complaining about.
(In reply to comment #9) > (From update of attachment 157607 [details]) > This appears to be missing a ChangeLog. I suspect that's what the queue was complaining about. Oh weird, when I ran update-webkit and then reuploaded the patch it stripped off the ChangeLog... Created attachment 158059 [details]
Patch for landing
Created attachment 158078 [details]
Patch
Finally get some ChangeLogs.
Created attachment 158080 [details]
Patch for landing
Comment on attachment 158080 [details] Patch for landing Clearing flags on attachment: 158080 Committed r125448: <http://trac.webkit.org/changeset/125448> All reviewed patches have been landed. Closing bug. |