Summary: | Structures should be swept after all other objects | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fpizlo, ggaren, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 92700 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Mark Hahnenberg
2012-07-30 14:25:19 PDT
Created attachment 155389 [details]
Patch
Comment on attachment 155389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155389&action=review > Source/JavaScriptCore/heap/HeapTimer.h:44 > + Kill it with fire! > Source/JavaScriptCore/heap/IncrementalSweeper.cpp:74 > + return !m_blocksToSweep.size() || m_currentBlockToSweepIndex >= m_blocksToSweep.size(); I can has assert that m_currentBlockToSweepIndex <= m_blocksToSweep.size() Committed r124123: <http://trac.webkit.org/changeset/124123> Comment on attachment 155389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155389&action=review > Source/JavaScriptCore/heap/IncrementalSweeper.cpp:83 > + MarkedBlock* block = m_blocksToSweep[m_currentBlockToSweepIndex]; > + if (block->onlyContainsStructures()) { > + m_currentBlockToSweepIndex++; > + continue; This logic gets a little whacky. Can't we just arrange for all the Structure blocks to be added to the array last, so we naturally sweep them last? Re-opened since this is blocked by 92700 Created attachment 155621 [details]
Patch
Committed r124265: <http://trac.webkit.org/changeset/124265> |