|Summary:||[chromium] Layout tests svg-filters.html and alpha.html are crashing intermittently|
|Product:||WebKit||Reporter:||Stephen White <senorblanco>|
|Component:||MathML||Assignee:||Alok Priyadarshi <alokp>|
|Severity:||Normal||CC:||alokp, cc-bugs, danakj, dglazkov, enne, eric, fred.wang, jamesr, peter+ews, senorblanco, vangelis, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Stephen White 2012-07-30 10:52:54 PDT
Comment 1 Alok Priyadarshi 2012-08-27 14:19:06 PDT
Accelerated painting used the compositor context to create and upload the tile textures. Now it seems we use two contexts - one that creates the texture and another to upload it. Although the texture is shared by the two contexts, it is not immediately available after creation to the context that uploads it. Flushing the context that creates it fixes the problem.
Comment 2 Alok Priyadarshi 2012-08-27 15:02:59 PDT
Created attachment 160818 [details] proposed patch
Comment 3 Alok Priyadarshi 2012-08-27 15:13:42 PDT
Created attachment 160822 [details] proposed patch sync'd with TOT.
Comment 4 Dana Jansens 2012-08-27 15:13:59 PDT
The Framebuffer texture updater isn't actually used unless enabled by command-line flags anywhere. At a minimum you will need to do something on other code paths such as BitmapCanvasLayerTextureUpdater (the default updater). But presumably you want to flush the sharedContext used for filters, not the context being used for upload, and we should do this once before any uploading takes place? Maybe CCTextureUpdateController?
Comment 5 Dana Jansens 2012-08-27 15:16:01 PDT
Oh I may be thinking backwards, the texture is created by our resource provider, but we're uploading using ganesh? Too used to the other way around. If so then ignore my last comment.
Comment 6 Alok Priyadarshi 2012-08-27 15:22:14 PDT
Right. This class is exclusively used by accelerated-painting path. AFAIK BitmapCanvasLayerTextureUpdater is not affected by using two contexts. In fact I am not even aware when we switched to using two contexts. I am not flushing the context that uploads. I am flushing the context that creates the textures. We could add a flush here: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/chromium/cc/CCResourceProvider.cpp#L124 (right after the texture is created), but that would affect other texture-updaters as well - even the ones that do not need it.
Comment 7 Dana Jansens 2012-08-27 15:27:42 PDT
Yeh this seems legit as presented, sorry for my misunderstanding!
Comment 8 WebKit Review Bot 2012-08-27 15:38:49 PDT
Comment on attachment 160822 [details] proposed patch Attachment 160822 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13648036
Comment 9 Peter Beverloo (cr-android ews) 2012-08-27 17:18:13 PDT
Comment on attachment 160822 [details] proposed patch Attachment 160822 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13635103
Comment 10 Alok Priyadarshi 2012-08-28 09:27:08 PDT
Created attachment 160998 [details] proposed patch sync'd again with TOT.
Comment 11 Alok Priyadarshi 2012-08-28 15:35:01 PDT
james: can you review it?
Comment 12 Alok Priyadarshi 2012-08-29 17:35:43 PDT
Comment 13 WebKit Review Bot 2012-08-31 11:24:03 PDT
Comment on attachment 160998 [details] proposed patch Clearing flags on attachment: 160998 Committed r127294: <http://trac.webkit.org/changeset/127294>
Comment 14 WebKit Review Bot 2012-08-31 11:24:07 PDT
All reviewed patches have been landed. Closing bug.
Comment 15 Alok Priyadarshi 2012-09-06 14:46:42 PDT
Created attachment 162592 [details] Adjusting TestExpectations Adjusting test expectations after watching test bots and flakiness dashboard. It seems the earlier patch indeed fixed the problem.
Comment 16 Alok Priyadarshi 2012-09-06 14:48:01 PDT
Stephen: Could you approve the TestExpectations patch. Thanks.
Comment 17 James Robinson 2012-09-06 14:48:13 PDT
Don't attach new patches to closed bugs - open a new bug for new patches if you want a review. For this, I'd just commit it.