Summary: | Refactor EventDispatcher::dispatchEvent() so that we can call each phase (Caputure, Target and Bubbling) of event dispatching separately. | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||||||||||||||
Component: | UI Events | Assignee: | Hayato Ito <hayato> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot | ||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | 92613, 92614, 92625 | ||||||||||||||||||||
Bug Blocks: | 91290 | ||||||||||||||||||||
Attachments: |
|
Description
Hayato Ito
2012-07-30 02:03:11 PDT
Created attachment 155245 [details]
wip
Created attachment 155264 [details]
wip
Created attachment 155266 [details]
'goto' is gone.
Created attachment 155280 [details]
sync ToT
Created attachment 155281 [details]
Fix weird ChangeLog enty
Comment on attachment 155281 [details] Fix weird ChangeLog enty Attachment 155281 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13392371 New failing tests: platform/chromium/compositing/accelerated-drawing/svg-filters.html platform/chromium/compositing/accelerated-drawing/alpha.html Created attachment 155300 [details]
Archive of layout-test-results from gce-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 155281 [details] Fix weird ChangeLog enty View in context: https://bugs.webkit.org/attachment.cgi?id=155281&action=review Neat! > Source/WebCore/dom/EventDispatcher.cpp:242 > + dispatchEventInitialize(event); This seems like a very function. Can we unroll it here? Created attachment 155403 [details]
unroll eventDispatchInitialize
Thank you for the review. (In reply to comment #8) > (From update of attachment 155281 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155281&action=review > > Neat! > > > Source/WebCore/dom/EventDispatcher.cpp:242 > > + dispatchEventInitialize(event); > > This seems like a very function. Can we unroll it here? Sure. Done. Comment on attachment 155403 [details]
unroll eventDispatchInitialize
ok, let's give it a try. Wow, we're getting rid of one of the oldest gotos in the code.
Comment on attachment 155403 [details] unroll eventDispatchInitialize Rejecting attachment 155403 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13389870 Created attachment 155689 [details]
Patch for landing
Comment on attachment 155689 [details] Patch for landing Clearing flags on attachment: 155689 Committed r124291: <http://trac.webkit.org/changeset/124291> All reviewed patches have been landed. Closing bug. |