Summary: | [Forms] Get rid of Element::isReadOnlyFormControl other than CSS related | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||||||||
Component: | Forms | Assignee: | yosin | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | eric, mifenton, tkent, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 92602 | ||||||||||||
Attachments: |
|
Description
yosin
2012-07-29 22:19:42 PDT
We'll replace CSS related Element::isReadOnlyFormControl() to Element::shouldMatchReadWriteSelector() Created attachment 155234 [details]
Patch 1
Comment on attachment 155234 [details] Patch 1 Attachment 155234 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13396230 Created attachment 155237 [details]
Patch 2
Created attachment 155242 [details]
Patch 3
Comment on attachment 155242 [details]
Patch 3
Could you review this patch?
Thanks in advance.
Comment on attachment 155242 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=155242&action=review > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:243 > - if (element->isReadOnlyFormControl() || !element->isEnabledFormControl()) > + if (!element->isEnabledFormControl()) > return false; > > if (isPopupInputField(element)) > return false; > > - return element->isTextFormControl() || element->isContentEditable(); > + if (element->isTextFormControl()) > + return !static_cast<HTMLTextFormControl*>(element)->readOnly(); > + > + return element->isContentEditable(); Is it safe to change the evaluation order? Created attachment 155417 [details]
Patch 4
Comment on attachment 155417 [details]
Patch 4
Could you review this patch?
Thanks in advance.
= Changes since the last review =
* WebKit/blackberry/WebKitSupport/DOMSupport.cpp: Keep original evaluation order for read only control check.
Comment on attachment 155417 [details]
Patch 4
Looks good.
Comment on attachment 155417 [details] Patch 4 Clearing flags on attachment: 155417 Committed r124146: <http://trac.webkit.org/changeset/124146> All reviewed patches have been landed. Closing bug. |