| Summary: | In flipped blocks, a point on the top edge of a box is considered outside the box (and vice versa) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||
| Component: | Layout and Rendering | Assignee: | mitz | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
mitz
2012-07-29 09:22:43 PDT
Created attachment 155174 [details]
When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa
Comment on attachment 155174 [details] When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa Attachment 155174 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13388197 New failing tests: fast/writing-mode/flipped-blocks-hit-test-line-edges.html Created attachment 155175 [details]
Archive of layout-test-results from gce-cr-linux-06
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 155174 [details] When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa View in context: https://bugs.webkit.org/attachment.cgi?id=155174&action=review > Source/WebCore/rendering/RenderBlock.cpp:4966 > + if (pointInLogicalContents.y() < firstRootBoxWithChildrenTop > + || (blocksAreFlipped && pointInLogicalContents.y() == firstRootBoxWithChildrenTop)) { Would be nice to have a helper function to make these tests more readable. A similar pattern is repeated 5 times in this patch. Fixed in <http://trac.webkit.org/r123980>. |