Summary: | [CSS Shaders] CSS parser rejects parameter names that are also CSS keywords | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Max Vujovic <mvujovic> | ||||||||||||||||
Component: | CSS | Assignee: | Max Vujovic <mvujovic> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | achicu, cmarcelo, dglazkov, macpherson, menard, webkit.review.bot | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Max Vujovic
2012-07-27 12:39:13 PDT
Created attachment 155323 [details]
Patch
Comment on attachment 155323 [details] Patch Attachment 155323 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13381877 New failing tests: css3/filters/custom/custom-filter-property-parsing.html Created attachment 155339 [details]
Archive of layout-test-results from gce-cr-linux-07
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 155356 [details]
Patch
Added an end-to-end test in addition to the parsing test. Added Chromium V8-specific parsing expectations.
Comment on attachment 155356 [details] Patch Attachment 155356 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13401173 New failing tests: css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html Created attachment 155366 [details]
Archive of layout-test-results from gce-cr-linux-06
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 155388 [details]
Patch
Added new test to Chromium TestExpectations for rebaselining on Win and Linux.
Created attachment 155575 [details]
Patch
Added more detail to the ChangeLogs, per Dirk's request on IRC.
Created attachment 155577 [details]
Patch
Reuploaded. Forgot to make a git --binary patch because of the pixel test.
Comment on attachment 155577 [details]
Patch
LGTM. r=me
Comment on attachment 155577 [details] Patch Clearing flags on attachment: 155577 Committed r124233: <http://trac.webkit.org/changeset/124233> All reviewed patches have been landed. Closing bug. |