Summary: | use createUninitialized when creating TypedArray from another array | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | arno. <a.renevier> | ||||
Component: | JavaScriptCore | Assignee: | arno. <a.renevier> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kbr, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
arno.
2012-07-27 11:08:01 PDT
Created attachment 155010 [details]
patch proposal
With this patch, performance test for construction with same typed array improves from 40ms to 25ms; construction from different typed array improves from 430ms to 270ms. construction from regular Array does not improve (and does not decrease)
Comment on attachment 155010 [details] patch proposal Arno: this looks fine, but would you please implement the same optimizations as in Bug 90838 and here for the V8 port? If not, would you please at least file a bug about doing so and CC me on it? r=me Comment on attachment 155010 [details] patch proposal Clearing flags on attachment: 155010 Committed r123935: <http://trac.webkit.org/changeset/123935> All reviewed patches have been landed. Closing bug. Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. |