Bug 92476

Summary: Web Inspector: InspectorPageAgent should ascertain document to be non-null in updateViewMetrics()
Product: WebKit Reporter: Vivek Galatage <vivekgalatage>
Component: Web Inspector (Deprecated)Assignee: Vivek Galatage <vivekgalatage>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 90675    
Attachments:
Description Flags
Patch none

Description Vivek Galatage 2012-07-27 02:38:00 PDT 
Now that https://bugs.webkit.org/show_bug.cgi?id=90675, goes on creating a blank page, with "about:blank" url, this new page will not be having a document object. When the call to Internals::closeDummyInspectorFrontend() is made, it tries to delete the newly created page. In turn, this calls InspectorController::disconnectFrontend() to inform all the agents to clearFrontend(). In case of InspectorPageAgent::clearFrontend(), calls disable() which in turn calls updateViewMetrics(). Now here the document object is NULL. Hence this should be checking for document pointer.
Comment 1 Vivek Galatage 2012-07-27 02:40:58 PDT 
Created attachment 154884 [details]
Patch
Comment 2 Pavel Feldman 2012-07-27 11:40:21 PDT 
Comment on attachment 154884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154884&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:970
> +    if (document)

Is there a test case for this?
Comment 3 WebKit Review Bot 2012-07-27 11:55:11 PDT 
Comment on attachment 154884 [details]
Patch

Clearing flags on attachment: 154884

Committed r123901: <http://trac.webkit.org/changeset/123901>
Comment 4 WebKit Review Bot 2012-07-27 11:55:16 PDT 
All reviewed patches have been landed.  Closing bug.