Bug 92456

Summary: Older ShadowDOM is still rendered when a new ShadowDOM is added when they don't have any InsertionPoints.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, morrita, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82313    
Attachments:
Description Flags
Repro
none
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-07
none
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2012-07-26 21:56:32 PDT
When we add a new ShadowDOM having no InsertionPoint, If older ShadowDOM does not have any InsertionPoint, the older ShadowDOM is still rendered.
Attachments
Repro (477 bytes, text/html)
2012-07-26 21:56 PDT, Shinya Kawanaka 		no flags
Details
Patch (3.82 KB, patch)
2012-07-26 22:07 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (8.96 KB, patch)
2012-07-26 23:15 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-07 (615.49 KB, application/zip)
2012-07-27 02:50 PDT, WebKit Review Bot 		no flags
Details
Patch (9.06 KB, patch)
2012-07-30 19:16 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.01 KB, patch)
2012-07-31 01:44 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-07-26 21:56:53 PDT
Created attachment 154837 [details] Repro
Shinya Kawanaka
Comment 2 2012-07-26 22:07:00 PDT
Created attachment 154840 [details] Patch
Shinya Kawanaka
Comment 3 2012-07-26 22:27:29 PDT
shinyak and morrita discussed this at offline, and we have determined the following: We should remove the InvalidationType, and add a method to make validity UNDETERMINED. We should call it before where using InvalidateAndForceReattach.
Shinya Kawanaka
Comment 4 2012-07-26 23:15:46 PDT
Created attachment 154850 [details] Patch
Shinya Kawanaka
Comment 5 2012-07-26 23:28:26 PDT
Comment on attachment 154850 [details] Patch Oops... This patch causes a lot of crashes.
WebKit Review Bot
Comment 6 2012-07-27 02:50:56 PDT
Comment on attachment 154850 [details] Patch Attachment 154850 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13374285 New failing tests: fast/dom/shadow/input-with-validation-without-shadow.html
WebKit Review Bot
Comment 7 2012-07-27 02:50:59 PDT
Created attachment 154888 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Shinya Kawanaka
Comment 8 2012-07-30 19:16:11 PDT
Created attachment 155422 [details] Patch
Hajime Morrita
Comment 9 2012-07-30 23:18:41 PDT
Comment on attachment 155422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155422&action=review > LayoutTests/fast/dom/shadow/invalidate-distribution-expected.html:4 > +<script src="resources/polyfill.js"></script> Do you need polyfill for this?
Shinya Kawanaka
Comment 10 2012-07-31 01:44:38 PDT
Created attachment 155466 [details] Patch for landing
Shinya Kawanaka
Comment 11 2012-07-31 01:45:30 PDT
Comment on attachment 155422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155422&action=review >> LayoutTests/fast/dom/shadow/invalidate-distribution-expected.html:4 >> +<script src="resources/polyfill.js"></script> > > Do you need polyfill for this? No. Thanks.
WebKit Review Bot
Comment 12 2012-07-31 06:15:43 PDT
Comment on attachment 155466 [details] Patch for landing Clearing flags on attachment: 155466 Committed r124196: <http://trac.webkit.org/changeset/124196>
WebKit Review Bot
Comment 13 2012-07-31 06:15:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.