Summary: | Web Inspector: Allow front_end to be loaded into an iframe | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | johnjbarton <johnjbarton> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
johnjbarton
2012-07-26 16:31:22 PDT
Created attachment 154791 [details]
Patch
Comment on attachment 154791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154791&action=review Please resubmit with proper changle log so that I could CQ+ it > Source/WebCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Remove this line Created attachment 154986 [details]
Patch
Note I changed the patch to catch one more "top." over in Source/WebKit/chromium. I think this change would only help if embedders can figure out how to use unmodified devtools extensions, but I added it to be consistent with the other changes. Comment on attachment 154986 [details] Patch Clearing flags on attachment: 154986 Committed r123902: <http://trac.webkit.org/changeset/123902> All reviewed patches have been landed. Closing bug. |