Bug 92412 – Double tap gesture should send dblclick event

• Component: UI Events
• Status: RESOLVED FIXED

[Rick Byers]

With ENABLE(GESTURE_EVENTS), we turn GestureTap into mousemove, mousedown, mouseup events (and so also a click event).  Similarly for GestureDoupleTab we should be adding a final dblclick event, and setting event.detail on each event correctly (1 for the first mousedown,mouseup,click, and 2 for the second).

[Rick Byers]

We can't actually do this with GestureDoubleTap.  Instead GestureTap is being modified to carry a tap count.

[Rick Byers]

Created attachment 156224 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 156224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156224&action=review

> Source/WebCore/page/EventHandler.cpp:2420
> +      return false;

Four-space indent

[Rick Byers]

Created attachment 156226 [details]
Patch

[Adam Barth]

Comment on attachment 156226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156226&action=review

> Source/WebCore/page/EventHandler.cpp:2418
> +    // a tap count. FIXME: We should probably remove GestureDoubleTap (http://wkb.uk/93045).

http://wkb.uk/93045   <--- This link doesn't work for me.  Is there a typo?

> Source/WebCore/page/EventHandler.cpp:2494
> +        tapCount = static_cast<int>(gestureEvent.deltaX());

Why is the tapCount stored in the deltaX?  That seems strange.

[Rick Byers]

*** Bug 93044 has been marked as a duplicate of this bug. ***

[Rick Byers]

Comment on attachment 156226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156226&action=review

>> Source/WebCore/page/EventHandler.cpp:2418
>> +    // a tap count. FIXME: We should probably remove GestureDoubleTap (http://wkb.uk/93045).
> 
> http://wkb.uk/93045   <--- This link doesn't work for me.  Is there a typo?

Yes, sorry - fixed.

>> Source/WebCore/page/EventHandler.cpp:2494
>> +        tapCount = static_cast<int>(gestureEvent.deltaX());
> 
> Why is the tapCount stored in the deltaX?  That seems strange.

Yes it is strange.  Right now deltaX/deltaY are overloaded for a variety of things depending on the event type, and rjkroege@ suggested I continue that pattern here temporarily until we clean this up.  I've just filed https://bugs.webkit.org/show_bug.cgi?id=93123 for myself to clean this up (one way or another).  Would you prefer I hold off on this CL (which makes the problem worse) until we do that?  I was concerned it would take a bit of time to update the various places properly without breaking anything, but I can start working on that right away.

[Rick Byers]

Created attachment 156383 [details]
Patch

[Adam Barth]

Comment on attachment 156383 [details]
Patch

I think it's ok to land this patch first because I trust you to work on Bug 93123 in the near term.

[Rick Byers]

Comment on attachment 156383 [details]
Patch

Thanks!  CQ?

[WebKit Review Bot]

Comment on attachment 156383 [details]
Patch

Rejecting attachment 156383 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13423901

[Rick Byers]

Created attachment 156439 [details]
Patch

[Rick Byers]

Comment on attachment 156439 [details]
Patch

I thought the CQ would auto-merge ChangeLogs properly?  Why would there be a merge conflict?

Patch updated to ToT (auto-merge worked fine for me).  Try CQ again?

[WebKit Review Bot]

Comment on attachment 156439 [details]
Patch

Clearing flags on attachment: 156439

Committed r124673: <http://trac.webkit.org/changeset/124673>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.