Bug 92401

Summary: Guard Prerenderer against inserting prerenders into detached documents.
Product: WebKit Reporter: Gavin Peters <gavinp>
Component: New BugsAssignee: Gavin Peters <gavinp>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gavin Peters
Reported 2012-07-26 11:13:11 PDT
Guard Prerenderer against inserting prerenders into detached documents.
Attachments
Patch (4.85 KB, patch)
2012-07-26 11:15 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Patch (4.83 KB, patch)
2012-07-26 11:56 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2012-07-26 11:15:10 PDT
Created attachment 154692 [details] Patch
Gavin Peters
Comment 2 2012-07-26 11:16:26 PDT
Japhet, WDYT?
Nate Chapin
Comment 3 2012-07-26 11:31:11 PDT
Comment on attachment 154692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154692&action=review > LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop.html:8 > + if (window.testRunner) { > + testRunner.notifyDone(); > + } Nit, no braces. > LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop.html:14 > + setTimeout(done, 0); Obligatory: any chance of avoiding the setTimeout()?
Gavin Peters
Comment 4 2012-07-26 11:56:03 PDT
Created attachment 154711 [details] Patch
Gavin Peters
Comment 5 2012-07-26 11:56:40 PDT
Thanks japhet!
Gavin Peters
Comment 6 2012-07-26 14:01:59 PDT
Comment on attachment 154711 [details] Patch Thanks to all reviewers. I double-double checked that removing the timer does not break the fix, and I'll modify some other tests accordingly. I'm also going to search for other possible post-removal DOM manipulations that can crash us, links or no links.
WebKit Review Bot
Comment 7 2012-07-26 15:07:43 PDT
Comment on attachment 154711 [details] Patch Clearing flags on attachment: 154711 Committed r123798: <http://trac.webkit.org/changeset/123798>
WebKit Review Bot
Comment 8 2012-07-26 15:07:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.