Summary: | Guard Prerenderer against inserting prerenders into detached documents. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Peters <gavinp> | ||||||
Component: | New Bugs | Assignee: | Gavin Peters <gavinp> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, japhet, jochen, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gavin Peters
2012-07-26 11:13:11 PDT
Created attachment 154692 [details]
Patch
Japhet, WDYT? Comment on attachment 154692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154692&action=review > LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop.html:8 > + if (window.testRunner) { > + testRunner.notifyDone(); > + } Nit, no braces. > LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop.html:14 > + setTimeout(done, 0); Obligatory: any chance of avoiding the setTimeout()? Created attachment 154711 [details]
Patch
Thanks japhet! Comment on attachment 154711 [details]
Patch
Thanks to all reviewers. I double-double checked that removing the timer does not break the fix, and I'll modify some other tests accordingly.
I'm also going to search for other possible post-removal DOM manipulations that can crash us, links or no links.
Comment on attachment 154711 [details] Patch Clearing flags on attachment: 154711 Committed r123798: <http://trac.webkit.org/changeset/123798> All reviewed patches have been landed. Closing bug. |