Bug 92391

Summary: [CSS Filters] Add V8 binding for WebKitCSSFilterValue
Product: WebKit Reporter: Max Vujovic <mvujovic>
Component: CSSAssignee: Max Vujovic <mvujovic>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, achicu, haraken, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
abarth: review+, webkit.review.bot: commit-queue-
Patch none

Description Max Vujovic 2012-07-26 09:50:09 PDT
WebKitCSSFilterValue is not supported in V8CSSValueCustom::toV8. Let's add it.
(It is currently supported in JSCSSValueCustom::toJS).

This will fix many tests whose chromium expected result looks like:
FAIL subRule.operationType should be 12 (of type number). Was undefined (of type undefined).

It will make them pass like this:
PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_CUSTOM
Comment 1 Max Vujovic 2012-07-26 10:09:46 PDT
Created attachment 154679 [details]
Patch
Comment 2 Max Vujovic 2012-07-26 11:57:13 PDT
Thanks Adam!
Comment 3 WebKit Review Bot 2012-07-26 12:48:21 PDT
Comment on attachment 154679 [details]
Patch

Rejecting attachment 154679 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 148290 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 148290.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13368002
Comment 4 Max Vujovic 2012-07-26 13:35:25 PDT
Created attachment 154737 [details]
Patch

Patch for landing. Fixed an OOPS in the ChangeLog.
Comment 5 WebKit Review Bot 2012-07-26 17:23:21 PDT
Comment on attachment 154737 [details]
Patch

Clearing flags on attachment: 154737

Committed r123818: <http://trac.webkit.org/changeset/123818>
Comment 6 WebKit Review Bot 2012-07-26 17:23:25 PDT
All reviewed patches have been landed.  Closing bug.