Bug 92391

Summary: [CSS Filters] Add V8 binding for WebKitCSSFilterValue
Product: WebKit Reporter: Max Vujovic <mvujovic>
Component: CSSAssignee: Max Vujovic <mvujovic>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, achicu, haraken, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
abarth: review+, webkit.review.bot: commit-queue-
Patch none

Max Vujovic
Reported 2012-07-26 09:50:09 PDT
WebKitCSSFilterValue is not supported in V8CSSValueCustom::toV8. Let's add it. (It is currently supported in JSCSSValueCustom::toJS). This will fix many tests whose chromium expected result looks like: FAIL subRule.operationType should be 12 (of type number). Was undefined (of type undefined). It will make them pass like this: PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_CUSTOM
Attachments
Patch (114.44 KB, patch)
2012-07-26 10:09 PDT, Max Vujovic 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (114.30 KB, patch)
2012-07-26 13:35 PDT, Max Vujovic 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Max Vujovic
Comment 1 2012-07-26 10:09:46 PDT
Created attachment 154679 [details] Patch
Max Vujovic
Comment 2 2012-07-26 11:57:13 PDT
Thanks Adam!
WebKit Review Bot
Comment 3 2012-07-26 12:48:21 PDT
Comment on attachment 154679 [details] Patch Rejecting attachment 154679 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 148290 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 148290. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13368002
Max Vujovic
Comment 4 2012-07-26 13:35:25 PDT
Created attachment 154737 [details] Patch Patch for landing. Fixed an OOPS in the ChangeLog.
WebKit Review Bot
Comment 5 2012-07-26 17:23:21 PDT
Comment on attachment 154737 [details] Patch Clearing flags on attachment: 154737 Committed r123818: <http://trac.webkit.org/changeset/123818>
WebKit Review Bot
Comment 6 2012-07-26 17:23:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.