Bug 92390 – Web Inspector: Profiles: cleanup HeapSnapshotReceiver interface

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

Remove callback parameter and return values from methods startLoading and finishLoading.
All implementations of HeapSnapshotReceiver honestly override interface methods now.

Created attachment 154672 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 154672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154672&action=review

Is there a chance we have a test for this?

> Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:75
> +        if (this._json)

What's the reason for splitting this into two methods?

Comment on attachment 154672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154672&action=review

These changes are covered with tests: see changed test file - it tests both HeapSnapshotLoader and HeapSnapshotLoaderProxy ("loading" file with HeapProfileHeader).

>> Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:75
>> +        if (this._json)
> 
> What's the reason for splitting this into two methods?

To make HeapSnapshotLoader implement receiver interface.

Practically we could remove @implements notation, leave this code
in peace and declare that "proxy" in not clearly "proxy", but
also "adapter"... But this way we would introduce one more entity
instead of reducing inconsistency.

[WebKit Review Bot]

Comment on attachment 154672 [details]
Patch

Clearing flags on attachment: 154672

Committed r124308: <http://trac.webkit.org/changeset/124308>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.