Bug 9237

Summary:

Autogenerate JSHTMLObjectElement and add GetSVGDocument()

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

DOM

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ddkilzer, ggaren, ian, mjs, oliver

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
incomplete patch (someone will need to finish it)	none
An updated patch which does not attempt any autobinding	none
patch for review -- no autogeneration attempted, just added GetSVGDocument	ap: review+

Eric Seidel (no email)

Reported 2006-06-02 11:02:41 PDT

This patch fixes a few things: 1. Adds "CanHavePluginObject" support to autogeneration 2. Adds "CheckDocumentSecurity" support to autogeneration 3. Autogenerates JSHTMLObjectElement 4. Fixes contentDocument on HTMLObjectElement 5. Adds getSVGDocument() support to HTMLObjectElement Issues with this patch: - CanHavePluginObject is not quite 100% implemented. The put() and callAsFunction() code has not been moved into the autogen script yet. - contentDocument does not work until the object has a renderer (bug 9201) - HTMLEmbedElement is not yet autogenerated

Attachments
incomplete patch (someone will need to finish it) (54.48 KB, patch) 2006-06-02 11:03 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
An updated patch which does not attempt any autobinding (20.03 KB, patch) 2006-07-21 04:45 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
patch for review -- no autogeneration attempted, just added GetSVGDocument (77.11 KB, patch) 2006-07-26 17:30 PDT, Eric Seidel (no email)	ap: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2006-06-02 11:03:54 PDT

Created attachment 8667 [details] incomplete patch (someone will need to finish it)

David Kilzer (:ddkilzer)

Comment 2 2006-06-24 15:07:44 PDT

Eric has been lobbying me to finish this bug. :)

Oliver Hunt

Comment 3 2006-07-06 16:02:04 PDT

i'll look into .. poor macdome, i'm going to be harassing you for a bit while i get back up to speed

Eric Seidel (no email)

Comment 4 2006-07-21 01:06:29 PDT

This doesn't quite apply cleanly anymore. :(

Oliver Hunt

Comment 5 2006-07-21 01:18:11 PDT

I know :-/ It hasn't applied cleanly for a while, i really need to learn perl properly before i start hacking it back though :(

Eric Seidel (no email)

Comment 6 2006-07-21 04:45:43 PDT

Created attachment 9598 [details] An updated patch which does not attempt any autobinding This patch still probably needs more lovin, including some test cases.

Eric Seidel (no email)

Comment 7 2006-07-26 17:30:40 PDT

Created attachment 9704 [details] patch for review -- no autogeneration attempted, just added GetSVGDocument

Alexey Proskuryakov

Comment 8 2006-07-26 22:01:21 PDT

Comment on attachment 9704 [details] patch for review -- no autogeneration attempted, just added GetSVGDocument There are a few ifdefs for SVG_SUPPORT missing, and the ChangeLog should mention the hspace/vspace fix. With that changes, r=me.

Eric Seidel (no email)

Comment 9 2006-07-26 22:24:28 PDT

I'm resolving this fixed, even though it doesn't actually autogenerate anything. Anders or someone else can open or clone this if they actually want to autogenerate HTMLObjectElement, etc. getSVGDocument() works now which is what I cared about.

Note You need to log in before you can comment on or make changes to this bug.