Summary: | Move region from HitTestResult to HitTestPoint | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||
Component: | Layout and Rendering | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Allan Sandfeld Jensen
2012-07-26 04:42:00 PDT
Created attachment 154610 [details]
Patch
Comment on attachment 154610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154610&action=review r=me > Source/WebCore/rendering/HitTestResult.cpp:107 > +HitTestPoint::HitTestPoint(const HitTestPoint& other, const LayoutSize& offset, RenderRegion* region) > + : m_point(other.m_point) > + , m_boundingBox(other.m_boundingBox) > + , m_transformedPoint(other.m_transformedPoint) > + , m_transformedRect(other.m_transformedRect) > + , m_region(region) I wonder who owns this point. Can it be deleted elsewhere, and we get garbage here?
>
> I wonder who owns this point. Can it be deleted elsewhere, and we get garbage here?
s/point/pointer/g
(In reply to comment #2) > (From update of attachment 154610 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154610&action=review > > r=me > > > Source/WebCore/rendering/HitTestResult.cpp:107 > > +HitTestPoint::HitTestPoint(const HitTestPoint& other, const LayoutSize& offset, RenderRegion* region) > > + : m_point(other.m_point) > > + , m_boundingBox(other.m_boundingBox) > > + , m_transformedPoint(other.m_transformedPoint) > > + , m_transformedRect(other.m_transformedRect) > > + , m_region(region) > > I wonder who owns this point. Can it be deleted elsewhere, and we get garbage here? It is owned by whoever created it, in this case in it just exists on the stack where it is created in renderflowthread, and is deleted automatically when that function returns. Comment on attachment 154610 [details] Patch Clearing flags on attachment: 154610 Committed r123754: <http://trac.webkit.org/changeset/123754> All reviewed patches have been landed. Closing bug. |