Bug 9236

Summary:

REGRESSION: focus method does not work on some elements before they are laid out

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

DOM

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

justin.garcia

Priority:

Keywords:

EasyFix, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch	ggaren: review+

Darin Adler

Reported 2006-06-02 08:47:51 PDT

The fast/forms/access-key.html layout test is failing. That's because the focus method isn't working because the page isn't laid out yet; the input element still has a width of 0. Easy to fix.

Attachments
patch (1.09 KB, patch) 2006-06-02 08:51 PDT, Darin Adler	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2006-06-02 08:48:16 PDT

This must be a regression since the test used to work.

Darin Adler

Comment 2 2006-06-02 08:51:01 PDT

Created attachment 8666 [details] patch

Darin Adler

Comment 3 2006-06-02 09:06:12 PDT

Mitz found where this regressed. Change 14666 for bug <rdar://problem/4567752> rearranged Element::focus, putting the isFocusable call before the layout.

Geoffrey Garen

Comment 4 2006-06-02 10:54:24 PDT

Comment on attachment 8666 [details] patch r=me

Timothy Hatcher

Comment 5 2006-06-02 17:15:41 PDT

Maciej landed this in r14699.

Note You need to log in before you can comment on or make changes to this bug.