Bug 92352

Summary:

Regression: r123696 made css3/flexbox tests failing

Product:

WebKit

Reporter:

Kristóf Kosztyó <kkristof>

Component:

Tools / Tests

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, gyuyoung.kim, kadam, kkristof, leviw, ossy, rakuco, szledan, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

92163

Attachments:

Description	Flags
css3/flexbox/flex-algorithm-min-max.html diff	none
css3/flexbox/flex-rounding.html diff	none
Patch	none

Description Kristóf Kosztyó 2012-07-26 02:02:56 PDT

After r123696 two tests start to fail on all platform except Chromium.

css3/flexbox/flex-algorithm-min-max.html
css3/flexbox/flex-rounding.html

Comment 1 Kristóf Kosztyó 2012-07-26 02:04:07 PDT

Created attachment 154583 [details]
css3/flexbox/flex-algorithm-min-max.html diff

Comment 2 Kristóf Kosztyó 2012-07-26 02:04:37 PDT

Created attachment 154584 [details]
css3/flexbox/flex-rounding.html diff

Comment 3 Kristóf Kosztyó 2012-07-26 02:12:04 PDT

On Qt the css3/flexbox/cross-axis-scrollbar.html starts to fail also.
I skipped them in r123717 <http://trac.webkit.org/changeset/123717> to paint the bot greener.
Please unskip them after the proper fix.

Comment 4 Tony Chang 2012-07-26 10:40:07 PDT

Sorry! Will fix.

Comment 5 Tony Chang 2012-07-26 11:06:54 PDT

Created attachment 154689 [details]
Patch

Comment 6 Tony Chang 2012-07-26 11:07:27 PDT

Levi, can you review?  I wasn't sure if I should check in failing results for css3/flexbox/flex-rounding.html for the other ports.

Comment 7 Levi Weintraub 2012-07-26 11:51:15 PDT

Comment on attachment 154689 [details]
Patch

Apologies for missing this before.

Comment 8 WebKit Review Bot 2012-07-26 12:56:49 PDT

Comment on attachment 154689 [details]
Patch

Clearing flags on attachment: 154689

Committed r123783: <http://trac.webkit.org/changeset/123783>

Comment 9 WebKit Review Bot 2012-07-26 12:56:55 PDT

All reviewed patches have been landed.  Closing bug.