Bug 92325

Summary:

[chromium] Remove assert when getting hardware renderingStats in software mode.

Product:

WebKit

Reporter:

Dave Tu <dtu>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, enne, fishd, jamesr, nduca, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Dave Tu

Reported 2012-07-25 17:50:26 PDT

[chromium] Add software paint time to GPU benchmarking renderingStats.

Attachments
Patch (5.00 KB, patch) 2012-07-26 18:36 PDT, Dave Tu	no flags	Details Formatted Diff Diff
Patch (2.58 KB, patch) 2012-07-30 18:24 PDT, Dave Tu	no flags	Details Formatted Diff Diff
Patch (2.75 KB, patch) 2012-07-31 15:05 PDT, Dave Tu	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dave Tu

Comment 1 2012-07-26 18:36:38 PDT

Created attachment 154807 [details] Patch

WebKit Review Bot

Comment 2 2012-07-26 18:58:20 PDT

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

Nat Duca

Comment 3 2012-07-27 09:05:24 PDT

Comment on attachment 154807 [details] Patch Do yo have a rason for doing this on webviewimpl instead of in render_widget? Afaict, its kinda easier to do it in rwh and gets the same number.

Dave Tu

Comment 4 2012-07-30 18:24:07 PDT

Created attachment 155413 [details] Patch

Nat Duca

Comment 5 2012-07-31 11:48:44 PDT

Comment on attachment 155413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155413&action=review LGTM. Enne or Jamesr for review. > Source/WebKit/chromium/public/WebWidget.h:226 > + // This call is relatively expensive in accelerated threaded mode, as it blocks on the compositor thread. You should probably put something saying "its safe to call in software mode, but it wont give you time spent on the software side."

Adrienne Walker

Comment 6 2012-07-31 12:04:21 PDT

Comment on attachment 155413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155413&action=review > Source/WebKit/chromium/ChangeLog:3 > + [chromium] Add software paint time to GPU benchmarking renderingStats. This patch did not match my expectations from this bug title. >> Source/WebKit/chromium/public/WebWidget.h:226 >> + // This call is relatively expensive in accelerated threaded mode, as it blocks on the compositor thread. > > You should probably put something saying "its safe to call in software mode, but it wont give you time spent on the software side." Also, "accelerated threaded" isn't usually a phrase that gets used. I'd say "threaded compositing mode" instead.

Dave Tu

Comment 7 2012-07-31 15:05:59 PDT

Created attachment 155642 [details] Patch

Adrienne Walker

Comment 8 2012-07-31 15:08:37 PDT

Comment on attachment 155642 [details] Patch R=me.

WebKit Review Bot

Comment 9 2012-08-03 16:20:29 PDT

Comment on attachment 155642 [details] Patch Clearing flags on attachment: 155642 Committed r124670: <http://trac.webkit.org/changeset/124670>

WebKit Review Bot

Comment 10 2012-08-03 16:20:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.