| Summary: | [chromium] Remove assert when getting hardware renderingStats in software mode. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Tu <dtu> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, enne, fishd, jamesr, nduca, tkent+wkapi, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dave Tu
2012-07-25 17:50:26 PDT
Created attachment 154807 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 154807 [details]
Patch
Do yo have a rason for doing this on webviewimpl instead of in render_widget? Afaict, its kinda easier to do it in rwh and gets the same number.
Created attachment 155413 [details]
Patch
Comment on attachment 155413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155413&action=review LGTM. Enne or Jamesr for review. > Source/WebKit/chromium/public/WebWidget.h:226 > + // This call is relatively expensive in accelerated threaded mode, as it blocks on the compositor thread. You should probably put something saying "its safe to call in software mode, but it wont give you time spent on the software side." Comment on attachment 155413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155413&action=review > Source/WebKit/chromium/ChangeLog:3 > + [chromium] Add software paint time to GPU benchmarking renderingStats. This patch did not match my expectations from this bug title. >> Source/WebKit/chromium/public/WebWidget.h:226 >> + // This call is relatively expensive in accelerated threaded mode, as it blocks on the compositor thread. > > You should probably put something saying "its safe to call in software mode, but it wont give you time spent on the software side." Also, "accelerated threaded" isn't usually a phrase that gets used. I'd say "threaded compositing mode" instead. Created attachment 155642 [details]
Patch
Comment on attachment 155642 [details]
Patch
R=me.
Comment on attachment 155642 [details] Patch Clearing flags on attachment: 155642 Committed r124670: <http://trac.webkit.org/changeset/124670> All reviewed patches have been landed. Closing bug. |