Bug 92302

Summary: [WebGL] GraphicsContext3D::readPixels has extraneous code from GraphicsContext3D::readPixelsIMG
Product: WebKit Reporter: Joshua Netterfield <jnetterfield>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Netterfield
Reported 2012-07-25 14:28:22 PDT
This causes readPixels to be limited to the size of the canvas and slows readPixels down.
Attachments
Patch (4.71 KB, patch)
2012-07-25 16:49 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2012-07-25 17:27 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Netterfield
Comment 1 2012-07-25 16:49:25 PDT
Created attachment 154486 [details] Patch
Noam Rosenthal
Comment 2 2012-07-25 16:55:52 PDT
Comment on attachment 154486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154486&action=review > Source/WebCore/ChangeLog:10 > + > + No new tests, because it introduces no new functionality, but it makes the WebGL aquarium demo > + run quite a bit smoother on SGX :) > + This seems to affect more than the BB port, please explain what this patch actually does.
Joshua Netterfield
Comment 3 2012-07-25 16:59:32 PDT
This code was added by mistake in https://bugs.webkit.org/show_bug.cgi?id=90567
Noam Rosenthal
Comment 4 2012-07-25 17:01:26 PDT
(In reply to comment #3) > This code was added by mistake in https://bugs.webkit.org/show_bug.cgi?id=90567 Ah, Ok. Might be worthwhile to mention this in the Changelog.
Joshua Netterfield
Comment 5 2012-07-25 17:27:06 PDT
Created attachment 154501 [details] Patch
WebKit Review Bot
Comment 6 2012-07-26 07:54:44 PDT
Comment on attachment 154501 [details] Patch Clearing flags on attachment: 154501 Committed r123745: <http://trac.webkit.org/changeset/123745>
WebKit Review Bot
Comment 7 2012-07-26 07:54:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.