Summary: | [WebGL] GraphicsContext3D::readPixels has extraneous code from GraphicsContext3D::readPixelsIMG | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Netterfield <jnetterfield> | ||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | noam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Joshua Netterfield
2012-07-25 14:28:22 PDT
Created attachment 154486 [details]
Patch
Comment on attachment 154486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154486&action=review > Source/WebCore/ChangeLog:10 > + > + No new tests, because it introduces no new functionality, but it makes the WebGL aquarium demo > + run quite a bit smoother on SGX :) > + This seems to affect more than the BB port, please explain what this patch actually does. This code was added by mistake in https://bugs.webkit.org/show_bug.cgi?id=90567 (In reply to comment #3) > This code was added by mistake in https://bugs.webkit.org/show_bug.cgi?id=90567 Ah, Ok. Might be worthwhile to mention this in the Changelog. Created attachment 154501 [details]
Patch
Comment on attachment 154501 [details] Patch Clearing flags on attachment: 154501 Committed r123745: <http://trac.webkit.org/changeset/123745> All reviewed patches have been landed. Closing bug. |