Bug 92202 – RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode

• Component: Layout and Rendering
• Status: RESOLVED FIXED

RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode

Created attachment 154238 [details]
Use logical coordinates consistently and correctly

[Beth Dakin]

Comment on attachment 154238 [details]
Use logical coordinates consistently and correctly

View in context: https://bugs.webkit.org/attachment.cgi?id=154238&action=review

> Source/WebCore/ChangeLog:12
> +        one of the sub-tests in the new regression test: (1) changed to compare childrenâs logical

Funny apostrophe character on children's?

> Source/WebCore/ChangeLog:13
> +        bounds against pointInLogicalContents, i.e. compare childernâs horizontal bounds to the

Here too.

> Source/WebCore/ChangeLog:14
> +        pointâs horizontal component; and (2) changed to use logicalTopForChild and

Here too.

> Source/WebCore/ChangeLog:15
> +        logicalHeightForChild, which account for this blockâs writing mode, instead of logicalTop

And here.

> Source/WebCore/ChangeLog:16
> +        and logicalBottom, which are based on the childâs writing mode.

And here. :-P

(In reply to comment #2)
> (From update of attachment 154238 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154238&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        one of the sub-tests in the new regression test: (1) changed to compare childrenâs logical
> 
> Funny apostrophe character on children's?

I blame bug 75394 :(

Fixed in <http://trac.webkit.org/r123571>.