Bug 92197 – [Chromium] Fix infinite loop issue for chromium android layout test

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Wei James (wistoch)]

[Chromium] Fix infinite loop issue for chromium android layout test

[Wei James (wistoch)]

Created attachment 154225 [details]
Patch

[Wei James (wistoch)]

t$ Tools/Scripts/run-webkit-tests --platform=chromium-android fast/html
Checking system dependencies ...
RuntimeError raised: maximum recursion depth exceeded                                                                                                                    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 131, in run
      unexpected_result_count = manager.run()
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 852, in run
      result_summary = self._set_up_run()
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 827, in _set_up_run
      self._port.setup_test_run()
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 249, in setup_test_run
      self._push_executable()
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 337, in _push_executable
      forwarder_host_path = self._path_to_forwarder()
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 301, in _path_to_forwarder
      return self._build_path('forwarder')
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path
      self._build_path(None, *comps)
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path
      self._build_path(None, *comps)
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path
      self._build_path(None, *comps)
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path
      self._build_path(None, *comps)
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path
      self._build_path(None, *comps)
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path
      self._build_path(None, *comps)
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path
      self._build_path(None, *comps)
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path
      self._build_path(None, *comps)
    File "/home/wistoch/workspace/chromium-android-x86/src/third_party/WebKit.git/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 283, in _build_path

[WebKit Review Bot]

Comment on attachment 154225 [details]
Patch

Attachment 154225 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13344091

New failing tests:
http/tests/security/script-crossorigin-loads-correctly.html
fast/loader/loadInProgress.html
fast/inline/positionedLifetime.html

[WebKit Review Bot]

Created attachment 154231 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Wei James (wistoch)]

(In reply to comment #4)
> Created an attachment (id=154231) [details]
> Archive of layout-test-results from gce-cr-linux-01
> 
> The attached test failures were seen while running run-webkit-tests on the chromium-ews.
> Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

the modification is in chromium-android port. should not impact these test cases.

[Adam Barth]

Yeah, sorry these are flaking out.

[Wei James (wistoch)]

Created attachment 154280 [details]
Patch

[Dirk Pranke]

Comment on attachment 154280 [details]
Patch

whoops :(

[WebKit Review Bot]

Comment on attachment 154280 [details]
Patch

Clearing flags on attachment: 154280

Committed r123681: <http://trac.webkit.org/changeset/123681>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.