Bug 92118

Summary: [BlackBerry] Update about:config lists
Product: WebKit Reporter: Joshua Netterfield <jnetterfield>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: efidler, mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Joshua Netterfield
Reported 2012-07-24 08:12:36 PDT
There are still some flags which are not reported in the about:config page. Add them.
Attachments
Patch (10.09 KB, patch)
2012-07-24 08:26 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (10.09 KB, patch)
2012-07-24 08:31 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (10.07 KB, patch)
2012-07-24 08:32 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (10.07 KB, patch)
2012-07-24 09:28 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (7.68 KB, patch)
2012-07-25 11:45 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Joshua Netterfield
Comment 1 2012-07-24 08:26:33 PDT
Created attachment 154068 [details] Patch
Antonio Gomes
Comment 2 2012-07-24 08:29:12 PDT
Comment on attachment 154068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154068&action=review > Source/WebKit/blackberry/WebCoreSupport/AboutDataUseFeatures.in:126 > +T is this a real one?
Joshua Netterfield
Comment 3 2012-07-24 08:31:26 PDT
Created attachment 154073 [details] Patch
Joshua Netterfield
Comment 4 2012-07-24 08:32:41 PDT
Created attachment 154074 [details] Patch
Joshua Netterfield
Comment 5 2012-07-24 09:26:29 PDT
Rob caught something - don't commit-queue+.
Joshua Netterfield
Comment 6 2012-07-24 09:28:56 PDT
Created attachment 154084 [details] Patch
Joshua Netterfield
Comment 7 2012-07-24 09:30:32 PDT
HAVE_SYSTEM_MALLOC is still used, but the HAVE() macro is not used to refer to it. Add it to the have list.
Rob Buis
Comment 8 2012-07-24 09:54:31 PDT
Comment on attachment 154084 [details] Patch Ok.
WebKit Review Bot
Comment 9 2012-07-24 10:06:03 PDT
Comment on attachment 154084 [details] Patch Clearing flags on attachment: 154084 Committed r123487: <http://trac.webkit.org/changeset/123487>
WebKit Review Bot
Comment 10 2012-07-24 10:06:07 PDT
All reviewed patches have been landed. Closing bug.
Joshua Netterfield
Comment 11 2012-07-25 11:45:20 PDT
Reopening to attach new patch.
Joshua Netterfield
Comment 12 2012-07-25 11:45:29 PDT
Created attachment 154406 [details] Patch
Joshua Netterfield
Comment 13 2012-07-25 11:46:32 PDT
There were duplicates in the lists I uploaded earlier. The above patch fixes this.
Rob Buis
Comment 14 2012-07-25 11:49:10 PDT
Comment on attachment 154406 [details] Patch LGTM.
WebKit Review Bot
Comment 15 2012-07-25 14:26:07 PDT
Comment on attachment 154406 [details] Patch Clearing flags on attachment: 154406 Committed r123660: <http://trac.webkit.org/changeset/123660>
WebKit Review Bot
Comment 16 2012-07-25 14:26:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.