Bug 92064

Summary: Add *explicit* keyword to constructor which has a parameter in bridge, history, loader and plugins
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2012-07-23 22:38:14 PDT
Some constructors missed to use *explicit* keyword. They need to be added *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
Attachments
Patch (11.87 KB, patch)
2012-07-23 22:40 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-07-23 22:40:29 PDT
Created attachment 153962 [details] Patch
Kentaro Hara
Comment 2 2012-07-24 00:49:24 PDT
Comment on attachment 153962 [details] Patch Good refactoring.
Kentaro Hara
Comment 3 2012-07-24 01:06:38 PDT
BTW, how many constructors are you trying to replace roughly? If the number is too many, I would recommend you to announce it to webkit-dev@. I believe this is a useful change and this change does not mess up git history, but someone might complain that "this is an only-style-fix change, which is forbidden in WebKit".
WebKit Review Bot
Comment 4 2012-07-24 01:43:07 PDT
Comment on attachment 153962 [details] Patch Clearing flags on attachment: 153962 Committed r123438: <http://trac.webkit.org/changeset/123438>
WebKit Review Bot
Comment 5 2012-07-24 01:43:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.