Bug 92045

Summary: [GTK] Update GraphicsLayerClutter
Product: WebKit Reporter: Joone Hur <joone>
Component: WebKitGTKAssignee: Joone Hur <joone>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, gustavo, mrobinson, rodrigo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73767, 105699    
Attachments:
Description Flags
Patch
none
Patch
gustavo: review+
Patch none

Joone Hur
Reported 2012-07-23 16:51:21 PDT
GraphicsLayerClutter will be updated for supporting CSS 3D transforms along with GraphicsLayerActor: https://bugs.webkit.org/show_bug.cgi?id=91940
Attachments
Patch (22.72 KB, patch)
2012-08-17 00:07 PDT, Joone Hur 		no flags
DetailsFormatted DiffDiff
Patch (22.67 KB, patch)
2012-12-11 06:07 PST, Joone Hur 		gustavo: review+
DetailsFormatted DiffDiff
Patch (22.62 KB, patch)
2012-12-11 08:35 PST, Joone Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2012-08-17 00:07:29 PDT
Created attachment 159019 [details] Patch
Joone Hur
Comment 2 2012-12-11 06:07:20 PST
Created attachment 178790 [details] Patch
Gustavo Noronha (kov)
Comment 3 2012-12-11 06:39:26 PST
Comment on attachment 178790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178790&action=review LGTM > Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:3 > + * Copyright (C) 2011,2012 Collabora Ltd. Missing space after comma > Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:431 > + // FIXME: It needs to paint content inside a layer. Not sure what this FIXME is saying.
Joone Hur
Comment 4 2012-12-11 08:08:48 PST
Comment on attachment 178790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178790&action=review Thanks for the review! >> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:3 >> + * Copyright (C) 2011,2012 Collabora Ltd. > > Missing space after comma There was the missing space in GraphicsLayerActor.h/cpp I've fixed them. >> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:431 >> + // FIXME: It needs to paint content inside a layer. > > Not sure what this FIXME is saying. Yes, I don't remember why I added this FIXME so I will remove it.
Joone Hur
Comment 5 2012-12-11 08:35:20 PST
Created attachment 178812 [details] Patch
WebKit Review Bot
Comment 6 2012-12-11 09:35:15 PST
Comment on attachment 178812 [details] Patch Clearing flags on attachment: 178812 Committed r137326: <http://trac.webkit.org/changeset/137326>
Note You need to log in before you can comment on or make changes to this bug.