Bug 92034

Summary: DFG is too aggressive in performing the specific value optimization on loads
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported 2012-07-23 15:10:03 PDT
The optimization is not valid if the structure holding the specific value is a dictionary. We can either flatten the dictionary, or skip the optimization.
Attachments
the patch (71.34 KB, patch)
2012-07-23 15:42 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-07-23 15:42:31 PDT
Created attachment 153880 [details] the patch
Mark Hahnenberg
Comment 2 2012-07-23 15:45:26 PDT
Comment on attachment 153880 [details] the patch r=me
Filip Pizlo
Comment 3 2012-07-23 15:46:38 PDT
Landed in http://trac.webkit.org/changeset/123394
Note You need to log in before you can comment on or make changes to this bug.