Bug 92030

Summary: [chromium] Fix unit tests in debug mode after r123375
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Shawn Singh
Reported 2012-07-23 14:47:38 PDT
A few unit tests were triggering assertions because of the refactoring done in r123375. That revision added an assertion to make sure that the root layer is not empty when given to calcDrawTransforms -- there is no reason to believe this assertion is too aggressive, and its good that it triggers. Patch coming in a moment that fixes the unit tests that trigger the assertion, they now use a non-zero size for the root layer.
Attachments
Patch (3.28 KB, patch)
2012-07-23 14:55 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2012-07-23 14:55:13 PDT
Created attachment 153868 [details] Patch
Shawn Singh
Comment 2 2012-07-23 14:59:46 PDT
I supposed it would help to CC a reviewer =)
Adrienne Walker
Comment 3 2012-07-23 15:22:41 PDT
Comment on attachment 153868 [details] Patch R=me.
WebKit Review Bot
Comment 4 2012-07-23 16:06:33 PDT
Comment on attachment 153868 [details] Patch Clearing flags on attachment: 153868 Committed r123398: <http://trac.webkit.org/changeset/123398>
WebKit Review Bot
Comment 5 2012-07-23 16:06:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.