Bug 91986
| Summary: | [CMake] Define constants in cmakeconfig.h instead of passing them directly via add_definitions() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Raphael Kubo da Costa (:rakuco)
The amount of constants for paths and other values we are passing via ADD_DEFINITIONS(-DFOO=bar) in our build system files is increasing. This is not the correct approach -- a cleaner way of passing values from the build system to source files is by using #cmakedefine, #cmakedefine01 or #define and have CMake replace the desired values via CONFIGURE_FILE().
We need to extend cmakeconfig.h.cmake and have it perhaps #include a port-specific config.h file which should be responsible for having these definitions.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |