Bug 91947

Summary: Rename TextCodecWinCE to TextCodecWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: WebCore Misc.Assignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Patrick R. Gansterer
Reported 2012-07-22 14:36:08 PDT
Rename TextCodecWinCE to TextCodecWin
Attachments
Patch (29.03 KB, patch)
2012-07-22 14:46 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (29.03 KB, patch)
2012-07-22 14:52 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (29.02 KB, patch)
2012-07-22 14:57 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-07-22 14:46:15 PDT
Created attachment 153704 [details] Patch
WebKit Review Bot
Comment 2 2012-07-22 14:50:08 PDT
Attachment 153704 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/text/win/TextCodecWin.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/text/win/TextCodecWin.h:35: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/text/win/TextCodecWin.h:61: The parameter name "receiver" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 3 2012-07-22 14:52:20 PDT
Created attachment 153705 [details] Patch
WebKit Review Bot
Comment 4 2012-07-22 14:55:43 PDT
Attachment 153705 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/text/win/TextCodecWin.h:35: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/text/win/TextCodecWin.h:61: The parameter name "receiver" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 5 2012-07-22 14:57:33 PDT
Created attachment 153706 [details] Patch
Ryosuke Niwa
Comment 6 2012-07-23 00:54:39 PDT
Comment on attachment 153706 [details] Patch rs=me.
WebKit Review Bot
Comment 7 2012-07-23 01:06:27 PDT
Comment on attachment 153706 [details] Patch Clearing flags on attachment: 153706 Committed r123311: <http://trac.webkit.org/changeset/123311>
WebKit Review Bot
Comment 8 2012-07-23 01:06:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.