Bug 91925

Summary: [JSC] REGRESSION(r122912): CodeGeneratorJS.pm generates wrong code for static attributes in supplemental IDL files
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, jochen, jonlee, oliver, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 91764    
Bug Blocks: 88919, 92413    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-07-21 03:21:34 PDT
r122912 implemented static attributes in CodeGeneratorJS.pm. However, It generates wrong code for static attributes in supplemental IDL files, as you can see in https://bugs.webkit.org/attachment.cgi?id=153666&action=review. We should fix it. I will upload a patch after bug 91764 is fixed.
Attachments
Patch (4.86 KB, patch)
2012-07-24 00:35 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-07-24 00:35:09 PDT
Created attachment 153977 [details] Patch
WebKit Review Bot
Comment 2 2012-07-24 01:45:19 PDT
Comment on attachment 153977 [details] Patch Clearing flags on attachment: 153977 Committed r123439: <http://trac.webkit.org/changeset/123439>
WebKit Review Bot
Comment 3 2012-07-24 01:45:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2012-07-24 12:52:57 PDT
<rdar://problem/11947923>
Note You need to log in before you can comment on or make changes to this bug.