Bug 91887

Summary: [BlackBerry] Add Cancel button for Select popup
Product: WebKit Reporter: Crystal Zhang <haizhang>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
tonikitoo: review+, tonikitoo: commit-queue-
updated patch
none
updated patch none

Crystal Zhang
Reported 2012-07-20 11:50:39 PDT
Add a cancel button for Select popup. (c++ part)
Attachments
patch (2.43 KB, patch)
2012-07-20 12:05 PDT, Crystal Zhang 		tonikitoo: review+
tonikitoo: commit-queue-
DetailsFormatted DiffDiff
updated patch (2.45 KB, patch)
2012-07-20 12:30 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
updated patch (2.45 KB, patch)
2012-07-20 12:43 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Crystal Zhang
Comment 1 2012-07-20 12:05:17 PDT
Created attachment 153556 [details] patch
Antonio Gomes
Comment 2 2012-07-20 12:15:29 PDT
Comment on attachment 153556 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=153556&action=review > Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:151 > + // "-1" means cancel. > + if (stringValue.contains("-1")) { nit: I would remove the comment, and make the code self-explanatory :) DEFINE_STATIC_LOCAL("-1", cancelValue) if (string.contains(cancelValue)) { blah;
Crystal Zhang
Comment 3 2012-07-20 12:30:42 PDT
Created attachment 153565 [details] updated patch
Crystal Zhang
Comment 4 2012-07-20 12:43:23 PDT
Created attachment 153569 [details] updated patch
WebKit Review Bot
Comment 5 2012-07-20 13:42:28 PDT
Comment on attachment 153569 [details] updated patch Clearing flags on attachment: 153569 Committed r123255: <http://trac.webkit.org/changeset/123255>
WebKit Review Bot
Comment 6 2012-07-20 13:42:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.