| Summary: | [chromium] Don't display fullscreen button for video elements not containing video | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andrew Scherkus <scherkus> | ||||||||
| Component: | New Bugs | Assignee: | Andrew Scherkus <scherkus> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, feature-media-reviews, fischman, silviapf, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 84672 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andrew Scherkus
2012-07-19 21:23:00 PDT
Created attachment 153397 [details]
Patch
Created attachment 153398 [details]
Patch
thanks! Committed r123272: <http://trac.webkit.org/changeset/123272> Reopening to attach new patch. Created attachment 155695 [details]
Patch
Comment on attachment 155695 [details] Patch Rejecting attachment 155695 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ts/svn-apply', u'--force']" exit_code: 9 cwd: /mnt/git/webkit-commit-queue/ Parsed 8 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Original content of LayoutTests/platform/chromium-linux/media/media-document-audio-repaint-expected.png mismatches at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 265. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 9 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13418017 pkasting beat me with http://trac.webkit.org/changeset/124284 (Just adding the link to the meta bug.) |