Bug 91682

Summary: config_standalone.py is crashing on apple win's cygwin port
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2012-07-18 15:28:05 PDT
this seems to be due to the top-level import of ctypes in webkitpy.common.system.executive.py, which is only needed on win32. I don't know what ctypes is doing to cause the problem, or why it is only happening in config_standalone.
Attachments
Patch (1.89 KB, patch)
2012-07-18 15:33 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-07-18 15:33:50 PDT
Created attachment 153108 [details] Patch
Dirk Pranke
Comment 2 2012-07-18 15:35:12 PDT
to reproduce you can run 'python config_standalone.py --mock Debug' from the cygwin command prompt, and you should see "Debug\nAborted" with python crashing at process exit :(. You of course may not be able to reproduce this, as it doesn't seem to happen on the bots.
Adam Roben (:aroben)
Comment 3 2012-07-19 06:11:40 PDT
Comment on attachment 153108 [details] Patch Too bad we can't use the win32api module instead. Ah, the joys of Cygwin!
WebKit Review Bot
Comment 4 2012-07-19 12:14:06 PDT
Comment on attachment 153108 [details] Patch Clearing flags on attachment: 153108 Committed r123133: <http://trac.webkit.org/changeset/123133>
WebKit Review Bot
Comment 5 2012-07-19 12:14:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.