Summary: | Previous API changes to Webframe causes failures in certain apps | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||||||
Component: | WebKit API | Assignee: | Roger Fong <roger_fong> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, gyuyoung.kim, jberlin, jhoneycutt, kaustubh.ra, rniwa, roger_fong, sam, simon.fraser, thorton, webkit-bug-importer, webkit.review.bot | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Windows 7 | ||||||||||||
Attachments: |
|
Description
Roger Fong
2012-07-18 12:50:12 PDT
Radar: <rdar://problem/11904605> Created attachment 153371 [details]
Patch to re add in API changes to WebFrame that previously made dependent apps crash
I also rearranged method definitions in WebFrame.h to match the idl file...though this wasn't necessary...
I can roll those back if people want me too...
Attachment 153371 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/win/WebFrame.h:243: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit/win/WebFrame.h:280: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Created an attachment (id=153371) [details] > Patch to re add in API changes to WebFrame that previously made dependent apps crash > > I also rearranged method definitions in WebFrame.h to match the idl file...though this wasn't necessary... > I can roll those back if people want me too... I'm thinking that making the minimum necessary change is probably best. Comment on attachment 153371 [details] Patch to re add in API changes to WebFrame that previously made dependent apps crash View in context: https://bugs.webkit.org/attachment.cgi?id=153371&action=review > Source/WebKit/win/ChangeLog:11 > + Changes to the WebFrame API causes certain apps to crash because of inconsistencies in the COM interface. > + The resumeAnimations and suspendAnimations are removed, which are still needed. > + The counterValueByElementId method was also removed, although is not needed there. > + However, for all of these methods, no method stubs were added where appropriate after removal. > + > + https://bugs.webkit.org/show_bug.cgi?id=91656 > + Radar: <rdar://problem/11904605> > + > + Reviewed by NOBODY (OOPS!). Format should be: <title> <bugzilla url> <radar url> <reviewed by> <long description> <file/change list> (i.e. remove the "Radar:" and move the long description below the reviewed by line). > Source/WebKit/win/ChangeLog:24 > + Rearranged ordering of methods of method definitions to match interface file. Ideally we'd do this in another patch (or not at all). Created attachment 153563 [details]
Rolled back previous cleanliness changes
and fixed changelog Created attachment 153632 [details]
Forgot to get rid of "Radar: " in changelog of previous patch
Comment on attachment 153632 [details] Forgot to get rid of "Radar: " in changelog of previous patch View in context: https://bugs.webkit.org/attachment.cgi?id=153632&action=review r=me > Source/WebKit/win/ChangeLog:3 > + Changes to the WebFrame API causes dependent apps to crash. Typo: cause, not causes. > Source/WebKit/win/ChangeLog:9 > + Changes to the WebFrame API causes certain apps to crash because of inconsistencies in the COM interface. Same here. Created attachment 154468 [details]
Fixed grammar in changelog
Comment on attachment 154468 [details]
Fixed grammar in changelog
r=me
Comment on attachment 154468 [details] Fixed grammar in changelog Clearing flags on attachment: 154468 Committed r123688: <http://trac.webkit.org/changeset/123688> All reviewed patches have been landed. Closing bug. |