Summary: | [Chromium] Recognize textareas and content-editable fields for the IME | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Beverloo <peter> | ||||
Component: | HTML Editing | Assignee: | Nate Chapin <japhet> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, japhet, olilan, tkent+wkapi, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 91648 | ||||||
Attachments: |
|
Description
Peter Beverloo
2012-07-18 12:47:01 PDT
I think Nate is working on this bug. Created attachment 153095 [details]
patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 153095 [details]
patch
Does this case any trouble for Chrome OS?
(In reply to comment #4) > (From update of attachment 153095 [details]) > Does this case any trouble for Chrome OS? Unless grep failed me, the new enum values should be treated exactly as the previous values were. Comment on attachment 153095 [details] patch Clearing flags on attachment: 153095 Committed r123036: <http://trac.webkit.org/changeset/123036> All reviewed patches have been landed. Closing bug. (In reply to comment #7) > All reviewed patches have been landed. Closing bug. Reverted r123036 for reason: Triggers some DCHECKs in Chromium browser_tests Committed r123120: <http://trac.webkit.org/changeset/123120> This should be ready to land again now that we've rolled Chromium DEPS, right? (In reply to comment #9) > This should be ready to land again now that we've rolled Chromium DEPS, right? Yep, I just started a build to double-check locally. Comment on attachment 153095 [details] patch Clearing flags on attachment: 153095 Committed r123361: <http://trac.webkit.org/changeset/123361> All reviewed patches have been landed. Closing bug. |