Bug 91654

Summary: [Chromium] Recognize textareas and content-editable fields for the IME
Product: WebKit Reporter: Peter Beverloo <peter>
Component: HTML EditingAssignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, japhet, olilan, tkent+wkapi, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91648    
Attachments:
Description Flags
patch none

Peter Beverloo
Reported 2012-07-18 12:47:01 PDT
Textareas and elements which are contenteditable should trigger Android's IME functionalities. Downstream CL: https://gerrit-int.chromium.org/#change,9991
Attachments
patch (1.89 KB, patch)
2012-07-18 14:50 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-07-18 14:25:53 PDT
I think Nate is working on this bug.
Nate Chapin
Comment 2 2012-07-18 14:50:41 PDT
Created attachment 153095 [details] patch
WebKit Review Bot
Comment 3 2012-07-18 14:54:33 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2012-07-18 15:05:46 PDT
Comment on attachment 153095 [details] patch Does this case any trouble for Chrome OS?
Nate Chapin
Comment 5 2012-07-18 15:11:12 PDT
(In reply to comment #4) > (From update of attachment 153095 [details]) > Does this case any trouble for Chrome OS? Unless grep failed me, the new enum values should be treated exactly as the previous values were.
WebKit Review Bot
Comment 6 2012-07-18 15:41:17 PDT
Comment on attachment 153095 [details] patch Clearing flags on attachment: 153095 Committed r123036: <http://trac.webkit.org/changeset/123036>
WebKit Review Bot
Comment 7 2012-07-18 15:41:37 PDT
All reviewed patches have been landed. Closing bug.
Nate Chapin
Comment 8 2012-07-19 10:38:02 PDT
(In reply to comment #7) > All reviewed patches have been landed. Closing bug. Reverted r123036 for reason: Triggers some DCHECKs in Chromium browser_tests Committed r123120: <http://trac.webkit.org/changeset/123120>
Adam Barth
Comment 9 2012-07-23 10:42:46 PDT
This should be ready to land again now that we've rolled Chromium DEPS, right?
Nate Chapin
Comment 10 2012-07-23 10:46:06 PDT
(In reply to comment #9) > This should be ready to land again now that we've rolled Chromium DEPS, right? Yep, I just started a build to double-check locally.
WebKit Review Bot
Comment 11 2012-07-23 12:31:58 PDT
Comment on attachment 153095 [details] patch Clearing flags on attachment: 153095 Committed r123361: <http://trac.webkit.org/changeset/123361>
WebKit Review Bot
Comment 12 2012-07-23 12:32:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.